Continues the earlier pass. Each sweep can only check crates whose
dependencies compiled, so every round reached deeper and uncovered
another layer: 16, 35, 7, 12, 15, 69, 31, 1, then a long tail. The spikes
are large crates unblocking — `project` in one round, the `editor` tree in
another — not new breakage.
Nearly all of it applied from rustc's own machine-applicable spans.
Judgement was needed in a few places: prost's `from_i32` becomes
`try_from(..).ok()` at 24 sites, written that way because every caller
wanted an `Option` and `.ok()` keeps the semantics identical; a
paren-matching rewrite rather than a regex, since the argument is often
itself a call. `criterion::black_box` moved to `std::hint`, `rand`'s
`choose_multiple` is `sample`, and `time::format_description::parse` is
`parse_borrowed::<2>`.
Two are deliberately marked rather than changed. `SettingsInputField`'s
four builder methods really are unused — the other `with_id` hits in the
tree are `window.with_id` — so they carry `#[allow(dead_code)]` and a note
rather than being deleted out of a fork. `open_ai`'s large `Err` variant
keeps its scoped allow for the reason given there.
One lint was ours: the panel had a manual checked division, now
`checked_div`.
Co-Authored-By: Claude Opus 5 <[email protected]>
4e1eb7ab71