`script/clippy` denies warnings, so a single failing crate takes the gate
down for everything that depends on it — which meant nobody was seeing
new lints either. Four passes, because each fix unblocks crates the
previous pass could not reach: 76 findings, then 32, then 11, then 5.
Most of it is mechanical and was applied from rustc's own
machine-applicable spans rather than by hand: 29 float literals needing an
explicit `f32` (a future-compat lint that becomes a hard error), redundant
references in format-family arguments, a `drain(..).collect()` that is
`mem::take`, a `clone` on a `Copy` type, manual `Option::filter`.
The rest needed reading. `quick_xml` renamed `unescape_value` to
`normalized_value`, which takes an XML version — `Implicit1_0` is the
right one, since SVG carries no declaration and that is precisely the
"assume 1.0" case the old method covered. `criterion::black_box` moved to
`std::hint`. `rand`'s `choose_multiple` is now `sample`. Protobuf
`from_i32` is `TryFrom`, taken as `try_from(..).ok()` where the caller
wanted an `Option` so the semantics do not shift.
One is deliberately not fixed. `open_ai`'s `RequestError` carries the
response `HeaderMap`, which is what makes the Err variant large; boxing it
is the real fix but the variant is built and matched across several
crates, so that is an API change and not something to slip into a lint
pass. It carries a scoped allow that says so.
Co-Authored-By: Claude Opus 5 <[email protected]>
da8430783a