jcp-receipt: move an orphaned doc comment onto the test it describes #209

Merged

dcharlot merged 1 commit from dcharlot/jcp-receipt-orphan-doc into main 2026-10-13 02:40:07 -04:00 AGit

Conversation 0 Commits 1 Files changed 1 +11 -6

dcharlot commented 2026-10-10 17:19:43 -04:00

Owner

Copy link

Revives #98 (opened 2026-09-19, 1063 commits behind main) by cherry-picking its one commit onto current main. Re-verified against main first: legacy_jcp1.json exists and carries both an allow and a deny, and jcp-conformance/tests/pack.rs reads it, so the corrected text is accurate. jcp-receipt 21 tests pass. Supersedes #98, which I will close.

Revives #98 (opened 2026-09-19, 1063 commits behind main) by cherry-picking its one commit onto current main. Re-verified against main first: legacy_jcp1.json exists and carries both an allow and a deny, and jcp-conformance/tests/pack.rs reads it, so the corrected text is accurate. jcp-receipt 21 tests pass. Supersedes #98, which I will close.

dcharlot added 1 commit 2026-10-10 17:19:43 -04:00

jcp-receipt: move an orphaned doc comment onto the test it describes ... b1686e1fc5

A paragraph headed "**The migration guarantee**" sits between two tests in
`jcp-receipt/src/lib.rs` with no item of its own. Rust therefore merges it into
the doc of the *next* item, `an_absent_environment_leaves_the_bytes_untouched` —
a test about environment bindings, which has nothing to do with legacy
receipts. It reads as documentation for a deleted test, and that is exactly how
I first read it.

It also names the wrong file. It says the bytes are "published in
`conformance/v1/vectors.json`"; they are in `conformance/v1/legacy_jcp1.json`,
and are byte-identical to the hex constant in `published_v1_receipts_still_verify`
(checked).

The paragraph now documents `published_v1_receipts_still_verify`, which is the
test that actually carries the guarantee, names `legacy_jcp1.json`, and notes
that the inlined constant is a copy of the file's **allow** envelope while the
file also carries a **deny** — both of which `jcp-conformance`'s
`tests/pack.rs` verifies against the file itself, via `extract` and so
`verify_cose_sign1`, requiring both verdicts to be present.

Doc comments only; `jcp-receipt` green.

This PR originally also added a `jcp-conformance/tests/pack.rs` reading the five
pack files nothing read. Main closed that independently in 1b3e3907, reading the
same files and reaching the same legacy-deny finding, so that half is dropped
rather than merged alongside. This correction is the part main did not make.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

dcharlot referenced this pull request 2026-10-10 17:20:24 -04:00

jcp-receipt: move an orphaned doc comment onto the test it describes #98

dcharlot referenced this pull request 2026-10-11 22:59:51 -04:00

wai-vector: the default stroke set and the test repertoire, as WSF1 sources expanded by Annex A, and the text vectors (D7-5) #224

dcharlot merged commit 94f3331d1f into main 2026-10-13 02:40:07 -04:00

dcharlot referenced this pull request from a commit 2026-10-13 02:40:08 -04:00

Merge pull request 'jcp-receipt: move an orphaned doc comment onto the test it describes' (#209) from dcharlot/jcp-receipt-orphan-doc into main

dcharlot referenced this pull request from a commit 2026-10-14 02:13:13 -04:00

Merge origin/main (at bd3983c6, with #229-#232, #235, #142, #209, #210) into wai/d2c-decoders-on-ops

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

Transaction-Science/open-standards!209

No description provided.