Approved by the owner on 2026-10-22. Procedure: change `channel`, run `rustup show`, then run the pipeline. What changed - rust-toolchain.toml and eoc/eoc-rs/rust-toolchain.toml: channel "1.98.0" becomes "1.99.1". These are the only two pins in the tree, and the root one governs every other cargo root. - 64 workflows under .github/workflows (the forge's CI): every `Install Rust 1.98.0`, `rustup toolchain install / default / component add / target add --toolchain 1.98.0` and `--default-toolchain 1.98.0` now names 1.99.1 (409 lines). Two of those lines are in build steps rather than install steps (wai-conformance.yml's two `wasm32 (unix)` steps each `rustup target add --toolchain`), and they move with the rest: a target added to a toolchain that is not installed is an error. - Left as they are, because they record what was measured on 1.98.0: standards-build.yml's "Verified on a native arm64 Linux container (rustc 1.98.0)", wai-conformance.yml's note on Rust 1.98's LLD 22, and the "rustc 1.98.0 (example)" strings in receipts, vectors and docs. The one-codegen-unit workaround that note explains also stays. 1.99.1 ships LLD 23.1.1, which the note says links those inputs, but removing the workaround should wait for a run at the CI path on x86_64. Why - 1.98.0 has a P-critical miscompile, rust-lang/rust#161441 (I-miscompile, regression-from-stable-to-stable). rustc emits a vacant (null) method slot in a trait-object vtable, so a safe dynamic call jumps to address zero (undefined behaviour). RELEASES.md records the fix in 1.98.1 ("rustc: fix miscompilation in generating vtables"). - 1.99.1 is the current stable (channel manifest dated 2026-10-15; rustc 58cf8f9c3 2026-10-13). It also fixes 1.99.0's own regressions: wcslen on UEFI and embedded targets, x86_64 FFI `bool` returns, and the rust-lld rpath on macOS. Evidence All of it ran on the build host ([email protected], aarch64-apple-darwin) through ~/kani-logs/remote/rb. Nothing was built on the dev Mac. - `rustup show`: the active toolchain is 1.99.1-aarch64-apple-darwin, "overridden by .../rust-toolchain.toml" (and by eoc/eoc-rs's own file there). rustc 1.99.1 (58cf8f9c3 2026-10-13), LLVM 23.1.1, clippy 0.1.99, rustfmt 1.10.0. The baseline is rustc 1.98.0 (88d9e12ae 2026-08-18). - Scope: every cargo root the pin governs, which is 46 of the 49 tracked lockfiles. The other three: two are vendored crates that resolve inside their parents, and wai/wai-rs/fuzz builds on its own pinned nightly. - Trees. The final tree is main at96117c570plus these two commits. Main moved four times while this ran, and each root's evidence comes from the newest tree it was run on: - 13 roots on the final tree: every root main changed after1a465f23d, and every root that consumes such a crate by path. - 12 roots on1a465f23dplus these two commits. - 7 roots onb16816671plus these two commits. - 14 roots onaa61ab3b9plus the pin change. For each root in the last three groups, checked with git diff and the lockfiles' path packages: none of its files, and no crate it reaches by path, differs on the final tree. - Each root got: (a) `cargo fmt --all -- --check` on the pin and on 1.98.0. The output is byte-identical in all 46. CI gates no root on rustfmt, and none is rustfmt-clean on main. (b) `cargo clippy --locked --keep-going --workspace --all-targets` on both toolchains, with the diagnostics compared line by line. After the previous commit, no root has a diagnostic that only 1.99.1 reports. openpay's one differing line is the same lint at the same site, reworded. (c) `cargo test --workspace --locked`. (d) the root's other CI steps that can run on this host: feature-gated tests, conformance suites, release-profile tests, the aac page-set checks, and every clippy -D warnings gate. The gates are standards-build's macOS meter and omni lints (jouleclaw-energy x2, jouleclaw-omni metal, jouleclaw-loader-gguf, jcp, proof, eoc, sandbox), wai-pack, wai-quantum-cli (default, no-default and metal), wai-quantum-service, wai-quantum-qpu and wai-quantum-desktop. - Totals: `cargo test --workspace` ran in 43 roots: 12,532 passed, 1 failed, 101 ignored. The other 3 roots are wasm32-only, and their `cargo build --release --target wasm32-unknown-unknown` passed. Every other CI step passed (62 of 62). - On the final tree: scripts/check-lockfiles.sh (cargo 1.99.1) found all 47 lockfiles current, and scripts/check-advisories.py passes. - tokio is 1.54.1 in every lockfile cargo reads. That is patched for both RUSTSEC-2026-0386 (>= 1.53.3) and RUSTSEC-2026-0384 (>= 1.54.1). The 1.53.1 in vendor/wtransport/Cargo.lock is the upstream file kept with the vendored source; cargo resolves wtransport inside its parents, and both gates skip that file. - What is not green, each one reproduced on 1.98.0: - wai-ops-gpu: under the debug profile, `corpus` trips the debug_assert at exec.rs:187 on both toolchains. CI runs it in release only, and that passes (6/6). - wai-ops: clippy::derived_hash_with_manual_eq (deny-by-default) on both toolchains. No CI job runs clippy there. - wai-vector/wasm: `--all-targets` cannot build the lib-test target (its own `panic_impl`) on either toolchain. `clippy --lib` for wasm32 reports 0 diagnostics on both. - eoc-cascade's hit_calibration_process_energy test reads real energy counters, and it fails some of the time on the loaded shared host. In interleaved runs each toolchain passed 18 of 20. The full eoc-rs suite passed on the final tree (741 passed). - Environment, not code: - wai-quantum-desktop embeds the Studio's build, so wai/quantum-studio was built first (`npm ci`, `node build.mjs`), as CI does. - Not covered here: the x86_64 and arm64 Linux and Windows legs; the GPU, NPU, FPGA, emulator and hardware-meter legs; wasm32 tests under Node, wasmtime and wasip2; and the fuzz job. Co-Authored-By: Claude Opus 5.5 <[email protected]>
137 lines
7.4 KiB
YAML
137 lines
7.4 KiB
YAML
name: wai-quantum variational and algorithm library
|
|
|
|
# The variational and algorithm library (wai/wai-quantum): a job's params
|
|
# bound exactly (engine::catalog::bind_params, a sweep fixing some of them),
|
|
# every gate's derivative by each parameter carried by the reader
|
|
# (qasm::tangents, refused with Q129 where it cannot follow one), exact
|
|
# gradients by adjoint differentiation and the parameter-shift rule,
|
|
# deterministic optimisers whose every step is a link of a digest chain, the
|
|
# variational eigensolver beside exact diagonalisation, QAOA for Max-Cut
|
|
# beside brute force (engine::variational), and the algorithm builders, each
|
|
# program checked against a reference built from its definition by the
|
|
# equivalence ladder's matrix and truth-table rungs (engine::algorithms,
|
|
# engine::equiv).
|
|
#
|
|
# Ground truth first: every gradient is held to one worked out by hand within
|
|
# its stated rounding bound, to central finite differences and to the other
|
|
# method; the spectrum to closed forms and to the trace and squared-norm
|
|
# invariants; QAOA at p = 1 to its closed form on an edge and a ring; phase
|
|
# and amplitude estimation to the Fejér distribution; the adder to a truth
|
|
# table written apart; QSVT to the Chebyshev polynomials of a signal and of a
|
|
# matrix. The answers' bytes are pinned, and the pins run on x86_64 and arm64
|
|
# here (and on every architecture wai-energy-receipts.yml's matrix runs); the
|
|
# browser engine holds the same bytes in wasm32 (wai-web-wasm.yml). The
|
|
# surfaces' tests run in wai-quantum-cli.yml, wai-quantum-service.yml and the
|
|
# contract (wai-quantum-contract.yml).
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
on:
|
|
push:
|
|
branches: [main]
|
|
paths:
|
|
- 'wai/wai-quantum/**'
|
|
- 'rust-toolchain.toml'
|
|
- '.github/workflows/wai-quantum-variational.yml'
|
|
pull_request:
|
|
paths:
|
|
- 'wai/wai-quantum/**'
|
|
- 'rust-toolchain.toml'
|
|
- '.github/workflows/wai-quantum-variational.yml'
|
|
|
|
jobs:
|
|
relevant:
|
|
name: does this change touch it
|
|
runs-on: linux-arm64
|
|
outputs:
|
|
run: ${{ steps.gate.outputs.run }}
|
|
steps:
|
|
- uses: actions/checkout@v5
|
|
with:
|
|
fetch-depth: 0
|
|
- id: gate
|
|
run: |
|
|
set -euo pipefail
|
|
r=$(python3 scripts/pr-touches-paths.py .github/workflows/wai-quantum-variational.yml \
|
|
"${{ github.event.pull_request.base.sha }}" \
|
|
"${{ github.event.pull_request.head.sha }}")
|
|
echo "this change touches the variational and algorithm library: $r"
|
|
echo "run=$r" >> "$GITHUB_OUTPUT"
|
|
|
|
native:
|
|
name: parameters, gradients, optimisers, VQE, QAOA and builders · ${{ matrix.os }}, release
|
|
needs: relevant
|
|
if: needs.relevant.outputs.run == 'true'
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
os: [linux, linux-arm64]
|
|
runs-on: ${{ matrix.os }}
|
|
timeout-minutes: 60
|
|
steps:
|
|
- uses: actions/checkout@v5
|
|
- name: Install Rust 1.99.1
|
|
shell: bash
|
|
run: |
|
|
export PATH="$HOME/.cargo/bin:$PATH"
|
|
command -v rustup >/dev/null 2>&1 || \
|
|
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile minimal --default-toolchain 1.99.1
|
|
rustup toolchain install 1.99.1 --profile minimal
|
|
rustup default 1.99.1
|
|
echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
|
|
# A module filter is satisfied by any one test of the module, so each
|
|
# new test is required by name to have run and passed.
|
|
- name: The library's tests, each required by name
|
|
shell: bash
|
|
working-directory: wai/wai-quantum
|
|
run: |
|
|
set -euo pipefail
|
|
cargo test --locked --release --features full --lib -- \
|
|
engine::variational:: engine::algorithms:: engine::equiv:: \
|
|
qasm::tests::a_gate_s_derivative_by_each_parameter_is_carried_to_it \
|
|
qasm::tests::a_parameter_the_derivative_cannot_follow_is_refused_on_its_line \
|
|
engine::catalog::tests::a_job_binds_its_parameters_exactly \
|
|
engine::sets::tests::a_sweep_binds_the_parameters_params_fix \
|
|
engine::schema::tests::the_variational_and_algorithm_answers_follow_their_schema \
|
|
engine::refusal:: qasm::diag:: 2>&1 | tee "$RUNNER_TEMP/variational.log"
|
|
grep -qE '^test result: ok\. [1-9][0-9]+ passed; 0 failed' "$RUNNER_TEMP/variational.log" || { echo "::error::the library's tests did not pass"; exit 1; }
|
|
for t in engine::variational::tests::each_method_gives_the_gradient_worked_out_by_hand \
|
|
engine::variational::tests::both_methods_agree_with_finite_differences_and_with_each_other \
|
|
engine::variational::tests::a_gradient_is_the_same_bytes_every_time \
|
|
engine::variational::tests::what_a_gradient_cannot_take_is_refused_with_its_code \
|
|
engine::variational::tests::the_ansatz_is_the_variational_ml_module_s_and_so_is_its_gradient \
|
|
engine::variational::tests::the_spectrum_is_the_closed_form_and_keeps_the_invariants \
|
|
engine::variational::tests::each_optimiser_reaches_the_minimum_and_is_deterministic \
|
|
engine::variational::tests::an_optimisation_s_receipt_and_chain_bind_every_step \
|
|
engine::variational::tests::vqe_finds_the_ground_energy_diagonalisation_gives \
|
|
engine::variational::tests::qaoa_is_max_cut_and_finds_an_optimal_cut \
|
|
engine::variational::tests::the_answers_are_the_same_bytes_on_every_platform \
|
|
engine::algorithms::tests::phase_estimation_reads_the_phase_with_the_fejer_distribution \
|
|
engine::algorithms::tests::amplitude_estimation_reads_the_amplitude \
|
|
engine::algorithms::tests::the_adder_is_its_truth_table \
|
|
engine::algorithms::tests::signal_processing_gives_its_polynomial \
|
|
engine::algorithms::tests::the_singular_value_transformation_applies_the_polynomial_to_the_matrix \
|
|
engine::algorithms::tests::a_builder_s_refusals_name_their_code \
|
|
qasm::tests::a_gate_s_derivative_by_each_parameter_is_carried_to_it \
|
|
qasm::tests::a_parameter_the_derivative_cannot_follow_is_refused_on_its_line \
|
|
engine::catalog::tests::a_job_binds_its_parameters_exactly \
|
|
engine::sets::tests::a_sweep_binds_the_parameters_params_fix \
|
|
engine::schema::tests::the_variational_and_algorithm_answers_follow_their_schema \
|
|
engine::refusal::tests::the_documented_table_is_the_table \
|
|
qasm::diag::tests::the_documented_table_is_the_table; do
|
|
grep -q "^test $t \.\.\. ok$" "$RUNNER_TEMP/variational.log" || { echo "::error::$t did not run and pass"; exit 1; }
|
|
done
|
|
# Without warnings: a feature gate that leaves code unreachable or a
|
|
# value unused in one feature set shows here.
|
|
- name: Each feature set the hosts build still builds, without warnings
|
|
shell: bash
|
|
working-directory: wai/wai-quantum
|
|
env:
|
|
RUSTFLAGS: -D warnings
|
|
run: |
|
|
set -euo pipefail
|
|
cargo check --locked --no-default-features --features quantum_engine --lib
|
|
cargo check --locked --no-default-features --features quantum_engine,quantum_receipt --lib
|
|
cargo check --locked --no-default-features --features quantum_engine,quantum_receipt,quantum_qec,quantum_noise --lib
|