Approved by the owner on 2026-10-22. Procedure: change `channel`, run `rustup show`, then run the pipeline. What changed - rust-toolchain.toml and eoc/eoc-rs/rust-toolchain.toml: channel "1.98.0" becomes "1.99.1". These are the only two pins in the tree, and the root one governs every other cargo root. - 64 workflows under .github/workflows (the forge's CI): every `Install Rust 1.98.0`, `rustup toolchain install / default / component add / target add --toolchain 1.98.0` and `--default-toolchain 1.98.0` now names 1.99.1 (409 lines). Two of those lines are in build steps rather than install steps (wai-conformance.yml's two `wasm32 (unix)` steps each `rustup target add --toolchain`), and they move with the rest: a target added to a toolchain that is not installed is an error. - Left as they are, because they record what was measured on 1.98.0: standards-build.yml's "Verified on a native arm64 Linux container (rustc 1.98.0)", wai-conformance.yml's note on Rust 1.98's LLD 22, and the "rustc 1.98.0 (example)" strings in receipts, vectors and docs. The one-codegen-unit workaround that note explains also stays. 1.99.1 ships LLD 23.1.1, which the note says links those inputs, but removing the workaround should wait for a run at the CI path on x86_64. Why - 1.98.0 has a P-critical miscompile, rust-lang/rust#161441 (I-miscompile, regression-from-stable-to-stable). rustc emits a vacant (null) method slot in a trait-object vtable, so a safe dynamic call jumps to address zero (undefined behaviour). RELEASES.md records the fix in 1.98.1 ("rustc: fix miscompilation in generating vtables"). - 1.99.1 is the current stable (channel manifest dated 2026-10-15; rustc 58cf8f9c3 2026-10-13). It also fixes 1.99.0's own regressions: wcslen on UEFI and embedded targets, x86_64 FFI `bool` returns, and the rust-lld rpath on macOS. Evidence All of it ran on the build host ([email protected], aarch64-apple-darwin) through ~/kani-logs/remote/rb. Nothing was built on the dev Mac. - `rustup show`: the active toolchain is 1.99.1-aarch64-apple-darwin, "overridden by .../rust-toolchain.toml" (and by eoc/eoc-rs's own file there). rustc 1.99.1 (58cf8f9c3 2026-10-13), LLVM 23.1.1, clippy 0.1.99, rustfmt 1.10.0. The baseline is rustc 1.98.0 (88d9e12ae 2026-08-18). - Scope: every cargo root the pin governs, which is 46 of the 49 tracked lockfiles. The other three: two are vendored crates that resolve inside their parents, and wai/wai-rs/fuzz builds on its own pinned nightly. - Trees. The final tree is main at96117c570plus these two commits. Main moved four times while this ran, and each root's evidence comes from the newest tree it was run on: - 13 roots on the final tree: every root main changed after1a465f23d, and every root that consumes such a crate by path. - 12 roots on1a465f23dplus these two commits. - 7 roots onb16816671plus these two commits. - 14 roots onaa61ab3b9plus the pin change. For each root in the last three groups, checked with git diff and the lockfiles' path packages: none of its files, and no crate it reaches by path, differs on the final tree. - Each root got: (a) `cargo fmt --all -- --check` on the pin and on 1.98.0. The output is byte-identical in all 46. CI gates no root on rustfmt, and none is rustfmt-clean on main. (b) `cargo clippy --locked --keep-going --workspace --all-targets` on both toolchains, with the diagnostics compared line by line. After the previous commit, no root has a diagnostic that only 1.99.1 reports. openpay's one differing line is the same lint at the same site, reworded. (c) `cargo test --workspace --locked`. (d) the root's other CI steps that can run on this host: feature-gated tests, conformance suites, release-profile tests, the aac page-set checks, and every clippy -D warnings gate. The gates are standards-build's macOS meter and omni lints (jouleclaw-energy x2, jouleclaw-omni metal, jouleclaw-loader-gguf, jcp, proof, eoc, sandbox), wai-pack, wai-quantum-cli (default, no-default and metal), wai-quantum-service, wai-quantum-qpu and wai-quantum-desktop. - Totals: `cargo test --workspace` ran in 43 roots: 12,532 passed, 1 failed, 101 ignored. The other 3 roots are wasm32-only, and their `cargo build --release --target wasm32-unknown-unknown` passed. Every other CI step passed (62 of 62). - On the final tree: scripts/check-lockfiles.sh (cargo 1.99.1) found all 47 lockfiles current, and scripts/check-advisories.py passes. - tokio is 1.54.1 in every lockfile cargo reads. That is patched for both RUSTSEC-2026-0386 (>= 1.53.3) and RUSTSEC-2026-0384 (>= 1.54.1). The 1.53.1 in vendor/wtransport/Cargo.lock is the upstream file kept with the vendored source; cargo resolves wtransport inside its parents, and both gates skip that file. - What is not green, each one reproduced on 1.98.0: - wai-ops-gpu: under the debug profile, `corpus` trips the debug_assert at exec.rs:187 on both toolchains. CI runs it in release only, and that passes (6/6). - wai-ops: clippy::derived_hash_with_manual_eq (deny-by-default) on both toolchains. No CI job runs clippy there. - wai-vector/wasm: `--all-targets` cannot build the lib-test target (its own `panic_impl`) on either toolchain. `clippy --lib` for wasm32 reports 0 diagnostics on both. - eoc-cascade's hit_calibration_process_energy test reads real energy counters, and it fails some of the time on the loaded shared host. In interleaved runs each toolchain passed 18 of 20. The full eoc-rs suite passed on the final tree (741 passed). - Environment, not code: - wai-quantum-desktop embeds the Studio's build, so wai/quantum-studio was built first (`npm ci`, `node build.mjs`), as CI does. - Not covered here: the x86_64 and arm64 Linux and Windows legs; the GPU, NPU, FPGA, emulator and hardware-meter legs; wasm32 tests under Node, wasmtime and wasip2; and the fuzz job. Co-Authored-By: Claude Opus 5.5 <[email protected]>
167 lines
7.3 KiB
YAML
167 lines
7.3 KiB
YAML
name: wai-sink-android native sink library
|
|
|
|
# The native sink's Kotlin library (wai/wai-sink-android, extensions/native-sink.md).
|
|
#
|
|
# On the linux-arm64 runner, the platform-free half's unit tests on the host JVM: libwai and the
|
|
# JNI layer built for the runner, then the corpus live-conformance/native-sink through the JNI
|
|
# layer, every case and every refused configuration; the page-parity bundle byte for byte; the
|
|
# C interface's statuses as the JNI layer carries them; the loopback relay over the reference
|
|
# package's floor (presented byte for byte, a changed fragment answered 502 on every request,
|
|
# ranges, content codings, an unsigned playlist refused, nothing answered outside the session's
|
|
# token); and the observation loop's hidden and idle endings with its clock advanced by the test.
|
|
# No Android SDK is used there.
|
|
#
|
|
# On the macOS runner, the host where the platform SDK, its NDK and its emulator are installed:
|
|
# libwai and the JNI layer for each ABI with the pinned NDK, the AAR, and the instrumented tests in
|
|
# a headless emulator (the host's ABI, arm64-v8a): the corpus and the relay on the device, the
|
|
# platform's media player library playing the floor through the sink to its end, a changed
|
|
# fragment refused on every retry, a session nobody can see ended as hidden, and the attention
|
|
# signals read from a real activity. Nothing listens beyond loopback.
|
|
#
|
|
# Push filters match the push's delta, so every path the jobs read is listed.
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
on:
|
|
push:
|
|
branches: [main]
|
|
paths:
|
|
- 'wai/wai-sink-android/**'
|
|
- 'wai/wai-rs/**'
|
|
- 'wai/wai-quantum/**'
|
|
- 'wai/wai-ops/**'
|
|
- 'wai/live-conformance/native-sink/**'
|
|
- 'wai/extensions/native-sink.md'
|
|
- 'rust-toolchain.toml'
|
|
- '.github/workflows/wai-sink-android.yml'
|
|
pull_request:
|
|
paths:
|
|
- 'wai/wai-sink-android/**'
|
|
- 'wai/wai-rs/**'
|
|
- 'wai/wai-quantum/**'
|
|
- 'wai/wai-ops/**'
|
|
- 'wai/live-conformance/native-sink/**'
|
|
- 'wai/extensions/native-sink.md'
|
|
- 'rust-toolchain.toml'
|
|
- '.github/workflows/wai-sink-android.yml'
|
|
|
|
jobs:
|
|
relevant:
|
|
name: does this change touch it
|
|
runs-on: linux-arm64
|
|
outputs:
|
|
run: ${{ steps.gate.outputs.run }}
|
|
steps:
|
|
- uses: actions/checkout@v5
|
|
with:
|
|
fetch-depth: 0
|
|
- id: gate
|
|
run: |
|
|
set -euo pipefail
|
|
r=$(python3 scripts/pr-touches-paths.py .github/workflows/wai-sink-android.yml \
|
|
"${{ github.event.pull_request.base.sha }}" \
|
|
"${{ github.event.pull_request.head.sha }}")
|
|
echo "this change touches wai-sink-android: $r"
|
|
echo "run=$r" >> "$GITHUB_OUTPUT"
|
|
|
|
jvm-linux-arm64:
|
|
name: the JNI layer and the platform-free half on the host JVM · linux-arm64
|
|
needs: relevant
|
|
if: needs.relevant.outputs.run == 'true'
|
|
runs-on: linux-arm64
|
|
timeout-minutes: 60
|
|
steps:
|
|
- uses: actions/checkout@v5
|
|
- name: Install Rust 1.99.1
|
|
shell: bash
|
|
run: |
|
|
export PATH="$HOME/.cargo/bin:$PATH"
|
|
command -v rustup >/dev/null 2>&1 || \
|
|
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile minimal --default-toolchain 1.99.1
|
|
rustup toolchain install 1.99.1 --profile minimal
|
|
rustup default 1.99.1
|
|
echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
|
|
# A JDK 17, from the image's packages when the image has none.
|
|
- name: JDK 17
|
|
shell: bash
|
|
run: |
|
|
set -euo pipefail
|
|
j="/usr/lib/jvm/java-17-openjdk-$(dpkg --print-architecture)"
|
|
if [ ! -x "$j/bin/javac" ]; then
|
|
sudo=$(command -v sudo || true)
|
|
$sudo apt-get update -qq
|
|
$sudo apt-get install -y -qq --no-install-recommends openjdk-17-jdk-headless >/dev/null
|
|
fi
|
|
test -f "$j/include/jni.h" || { echo "::error::no JDK 17 with jni.h at $j"; exit 1; }
|
|
echo "JAVA_HOME=$j" >> "$GITHUB_ENV"
|
|
- name: libwai and the JNI layer for this runner
|
|
shell: bash
|
|
working-directory: wai/wai-sink-android
|
|
run: bash scripts/build-native.sh host
|
|
# The pinned Gradle and the build's dependencies are kept on the runner's cache volume when
|
|
# it has one.
|
|
- name: The unit tests
|
|
shell: bash
|
|
working-directory: wai/wai-sink-android
|
|
run: |
|
|
set -euo pipefail
|
|
cache=/ci-cache/wai-sink-android
|
|
mkdir -p "$cache" 2>/dev/null || cache="$RUNNER_TEMP/wai-sink-android"
|
|
export WAI_SINK_GRADLE_DISTS="$cache/dists" GRADLE_USER_HOME="$cache/gradle-home"
|
|
bash scripts/gradle.sh -Pwai.sink.jvmOnly=true :core:test
|
|
python3 -I - core/build/test-results/test <<'PY'
|
|
import sys, pathlib, xml.etree.ElementTree as ET
|
|
runs = {}
|
|
tests = fails = skips = 0
|
|
for f in pathlib.Path(sys.argv[1]).glob("*.xml"):
|
|
s = ET.parse(f).getroot()
|
|
tests += int(s.get("tests", 0)); fails += int(s.get("failures", 0)) + int(s.get("errors", 0)); skips += int(s.get("skipped", 0))
|
|
runs[s.get("name").split(".")[-1]] = int(s.get("tests", 0))
|
|
print(f"unit tests: {tests} run, {fails} failed, {skips} skipped: {runs}")
|
|
need = {"CorpusTest", "RelayTest", "SessionDriverTest", "JsonTest"}
|
|
missing = sorted(c for c in need if runs.get(c, 0) == 0)
|
|
if missing: print(f"::error::these classes ran no test: {missing}")
|
|
sys.exit(0 if tests > 0 and fails == 0 and skips == 0 and not missing else 1)
|
|
PY
|
|
|
|
android-macos:
|
|
name: every ABI, the AAR, and the instrumented tests in a headless emulator · macos
|
|
needs: relevant
|
|
if: needs.relevant.outputs.run == 'true'
|
|
runs-on: macos
|
|
timeout-minutes: 90
|
|
steps:
|
|
- uses: actions/checkout@v5
|
|
# launchd's PATH omits cargo on the macOS host runner.
|
|
- name: Put cargo on PATH
|
|
shell: bash
|
|
run: echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
|
|
- name: The targets the ABIs need
|
|
shell: bash
|
|
run: rustup target add aarch64-linux-android armv7-linux-androideabi x86_64-linux-android
|
|
- name: libwai and the JNI layer for each ABI
|
|
shell: bash
|
|
working-directory: wai/wai-sink-android
|
|
run: nice -n 10 bash scripts/build-native.sh android
|
|
- name: The AAR
|
|
shell: bash
|
|
working-directory: wai/wai-sink-android
|
|
run: |
|
|
set -euo pipefail
|
|
nice -n 10 bash scripts/gradle.sh :sink:assembleRelease
|
|
aar=sink/build/outputs/aar/sink-release.aar
|
|
# The listing is read whole, then searched: under pipefail, `unzip -l | grep -q` fails
|
|
# whenever grep stops at its first match before unzip has written the rest (SIGPIPE).
|
|
list="$(unzip -l "$aar")"
|
|
for abi in arm64-v8a armeabi-v7a x86_64; do
|
|
for so in libwai.so libwai_sink_jni.so; do
|
|
grep -q " jni/$abi/$so\$" <<<"$list" || { echo "::error::the AAR has no jni/$abi/$so"; echo "$list"; exit 1; }
|
|
done
|
|
done
|
|
grep -q ' classes.jar$' <<<"$list" || { echo "::error::the AAR has no classes"; echo "$list"; exit 1; }
|
|
- name: The instrumented tests in a headless emulator
|
|
shell: bash
|
|
working-directory: wai/wai-sink-android
|
|
run: nice -n 10 bash scripts/test-emulator.sh
|