open-standards/.github/workflows/wai-ops.yml
Transaction Science 3b4b6059f5 toolchain: Rust 1.98.0 -> 1.99.1 (change-controlled pin)
Approved by the owner on 2026-10-22. Procedure: change `channel`, run
`rustup show`, then run the pipeline.

What changed
- rust-toolchain.toml and eoc/eoc-rs/rust-toolchain.toml: channel "1.98.0"
  becomes "1.99.1". These are the only two pins in the tree, and the root one
  governs every other cargo root.
- 64 workflows under .github/workflows (the forge's CI): every `Install Rust
  1.98.0`, `rustup toolchain install / default / component add / target add
  --toolchain 1.98.0` and `--default-toolchain 1.98.0` now names 1.99.1
  (409 lines). Two of those lines are in build steps rather than install
  steps (wai-conformance.yml's two `wasm32 (unix)` steps each
  `rustup target add --toolchain`), and they move with the rest: a target
  added to a toolchain that is not installed is an error.
- Left as they are, because they record what was measured on 1.98.0:
  standards-build.yml's "Verified on a native arm64 Linux container (rustc
  1.98.0)", wai-conformance.yml's note on Rust 1.98's LLD 22, and the
  "rustc 1.98.0 (example)" strings in receipts, vectors and docs. The
  one-codegen-unit workaround that note explains also stays. 1.99.1 ships
  LLD 23.1.1, which the note says links those inputs, but removing the
  workaround should wait for a run at the CI path on x86_64.

Why
- 1.98.0 has a P-critical miscompile, rust-lang/rust#161441 (I-miscompile,
  regression-from-stable-to-stable). rustc emits a vacant (null) method slot
  in a trait-object vtable, so a safe dynamic call jumps to address zero
  (undefined behaviour). RELEASES.md records the fix in 1.98.1 ("rustc: fix
  miscompilation in generating vtables").
- 1.99.1 is the current stable (channel manifest dated 2026-10-15; rustc
  58cf8f9c3 2026-10-13). It also fixes 1.99.0's own regressions: wcslen on
  UEFI and embedded targets, x86_64 FFI `bool` returns, and the rust-lld rpath
  on macOS.

Evidence
All of it ran on the build host ([email protected], aarch64-apple-darwin)
through ~/kani-logs/remote/rb. Nothing was built on the dev Mac.

- `rustup show`: the active toolchain is 1.99.1-aarch64-apple-darwin,
  "overridden by .../rust-toolchain.toml" (and by eoc/eoc-rs's own file
  there). rustc 1.99.1 (58cf8f9c3 2026-10-13), LLVM 23.1.1, clippy 0.1.99,
  rustfmt 1.10.0. The baseline is rustc 1.98.0 (88d9e12ae 2026-08-18).
- Scope: every cargo root the pin governs, which is 46 of the 49 tracked
  lockfiles. The other three: two are vendored crates that resolve inside
  their parents, and wai/wai-rs/fuzz builds on its own pinned nightly.
- Trees. The final tree is main at 96117c570 plus these two commits. Main
  moved four times while this ran, and each root's evidence comes from the
  newest tree it was run on:
  - 13 roots on the final tree: every root main changed after 1a465f23d,
    and every root that consumes such a crate by path.
  - 12 roots on 1a465f23d plus these two commits.
  - 7 roots on b16816671 plus these two commits.
  - 14 roots on aa61ab3b9 plus the pin change.
  For each root in the last three groups, checked with git diff and the
  lockfiles' path packages: none of its files, and no crate it reaches by
  path, differs on the final tree.
- Each root got:
  (a) `cargo fmt --all -- --check` on the pin and on 1.98.0. The output is
      byte-identical in all 46. CI gates no root on rustfmt, and none is
      rustfmt-clean on main.
  (b) `cargo clippy --locked --keep-going --workspace --all-targets` on both
      toolchains, with the diagnostics compared line by line. After the
      previous commit, no root has a diagnostic that only 1.99.1 reports.
      openpay's one differing line is the same lint at the same site,
      reworded.
  (c) `cargo test --workspace --locked`.
  (d) the root's other CI steps that can run on this host: feature-gated
      tests, conformance suites, release-profile tests, the aac page-set
      checks, and every clippy -D warnings gate. The gates are
      standards-build's macOS meter and omni lints (jouleclaw-energy x2,
      jouleclaw-omni metal, jouleclaw-loader-gguf, jcp, proof, eoc, sandbox),
      wai-pack, wai-quantum-cli (default, no-default and metal),
      wai-quantum-service, wai-quantum-qpu and wai-quantum-desktop.
- Totals: `cargo test --workspace` ran in 43 roots: 12,532 passed, 1 failed,
  101 ignored. The other 3 roots are wasm32-only, and their
  `cargo build --release --target wasm32-unknown-unknown` passed. Every
  other CI step passed (62 of 62).
- On the final tree: scripts/check-lockfiles.sh (cargo 1.99.1) found all 47
  lockfiles current, and scripts/check-advisories.py passes.
- tokio is 1.54.1 in every lockfile cargo reads. That is patched for both
  RUSTSEC-2026-0386 (>= 1.53.3) and RUSTSEC-2026-0384 (>= 1.54.1). The 1.53.1
  in vendor/wtransport/Cargo.lock is the upstream file kept with the vendored
  source; cargo resolves wtransport inside its parents, and both gates skip
  that file.
- What is not green, each one reproduced on 1.98.0:
  - wai-ops-gpu: under the debug profile, `corpus` trips the debug_assert at
    exec.rs:187 on both toolchains. CI runs it in release only, and that
    passes (6/6).
  - wai-ops: clippy::derived_hash_with_manual_eq (deny-by-default) on both
    toolchains. No CI job runs clippy there.
  - wai-vector/wasm: `--all-targets` cannot build the lib-test target (its
    own `panic_impl`) on either toolchain. `clippy --lib` for wasm32 reports
    0 diagnostics on both.
  - eoc-cascade's hit_calibration_process_energy test reads real energy
    counters, and it fails some of the time on the loaded shared host. In
    interleaved runs each toolchain passed 18 of 20. The full eoc-rs suite
    passed on the final tree (741 passed).
- Environment, not code:
  - wai-quantum-desktop embeds the Studio's build, so wai/quantum-studio was
    built first (`npm ci`, `node build.mjs`), as CI does.
- Not covered here: the x86_64 and arm64 Linux and Windows legs; the GPU,
  NPU, FPGA, emulator and hardware-meter legs; wasm32 tests under Node,
  wasmtime and wasip2; and the fuzz job.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-11-03 00:45:20 -05:00

299 lines
13 KiB
YAML

name: wai-ops integer operators
# The integer operator set (wai/extensions/integer-operators.md), checked on every
# fabric leg the corpus has today. Every leg recomputes every vector file of
# wai/ops-conformance/ from its inputs and requires the committed bytes:
#
# - Linux x86_64, Linux arm64 and macOS arm64, natively, debug and release: the
# unit tests (the bound rules against hand-computed values among them), the
# goldens (every committed parameter set lowered, loaded through load step 8 and
# decoded through the interpreter to its committed output digest), the step-8
# and verdict tests and the doc tests; `wai-verify vectors verify`, which also
# re-lowers every set, recomputes its bounds certificate from the committed
# lowered graphs and regenerates the whole corpus, so every certificate is
# byte-identical on every leg; and `wai-verify bounds` on the falsification sets
# of integer-operators §14.3, which must exit 1, and on committed sets, which
# must exit 0 under their profile;
# - WASI (wasm32-wasip2) under wasmtime, a 32-bit target: the same tests, and the
# same `vectors verify`;
# - a browser's engine (wasm32-unknown-unknown) under Node: the recomputation of
# every vector file;
# - the independent checker, tools/wai_ops_check.py: Python standard library only,
# sharing no code with wai-ops, rewrites every vector file and every lowered graph,
# and, as a second certifier, every certificate, the falsification sets' included
# (each must fail the profile it claims).
#
# There is no Windows leg: the Windows runner has been offline since 2026-08-28.
# One run per branch at a time. A push supersedes the run before it.
#
# There is one `macos` runner and it is the dev Mac, so every macOS job in this repo
# queues on it; only the newest commit's verdict is wanted, so older runs are
# cancelled. `cancel-in-progress: true` also applies to `main`, which advances by
# merge commits whose tree contains the commits before them.
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
on:
pull_request:
paths:
- 'wai/wai-ops/**'
# The certifier, the lowerings and the corpus tool, and the Kani host they share.
- 'wai/wai-verify/**'
- 'wai/ops-conformance/**'
- 'wai/tools/wai_ops_*.py'
# The text the checker is held to.
- 'wai/extensions/integer-operators.md'
# Every committed parameter set the corpus lowers, and the digests the goldens
# compare against (neural-conformance/sha256.json among them).
- 'wai/neural-conformance/**'
- 'wai/wai-rs/tests/vectors/int_hyper/**'
- 'wai/wai-rs/tests/vectors/int_audio/**'
- 'wai/wai-rs/tests/vectors/int_splat/**'
- 'wai/wai-rs/tests/vectors/int_mlicpp/**'
- 'wai/wai-rs/tests/vectors/int_world/**'
- 'wai/wai-rs/tests/vectors/int_world2/**'
- '.github/workflows/wai-ops.yml'
push:
branches:
- main
paths:
- 'wai/wai-ops/**'
# The certifier, the lowerings and the corpus tool, and the Kani host they share.
- 'wai/wai-verify/**'
- 'wai/ops-conformance/**'
- 'wai/tools/wai_ops_*.py'
- 'wai/extensions/integer-operators.md'
- 'wai/neural-conformance/**'
- 'wai/wai-rs/tests/vectors/int_hyper/**'
- 'wai/wai-rs/tests/vectors/int_audio/**'
- 'wai/wai-rs/tests/vectors/int_splat/**'
- 'wai/wai-rs/tests/vectors/int_mlicpp/**'
- 'wai/wai-rs/tests/vectors/int_world/**'
- 'wai/wai-rs/tests/vectors/int_world2/**'
- '.github/workflows/wai-ops.yml'
jobs:
# Does this pull request's own diff touch the paths below? This forge matches a
# workflow's `paths:` against the push, so a merge of main into a branch fires the
# workflow whatever the pull request changes; every job here waits on this answer.
# A push to main, a schedule, or anything the script cannot determine answers
# `true` (scripts/pr-touches-paths.py).
relevant:
name: does this change touch it
runs-on: linux-arm64
outputs:
run: ${{ steps.gate.outputs.run }}
steps:
- uses: actions/checkout@v5
with:
fetch-depth: 0
- id: gate
run: |
set -euo pipefail
r=$(python3 scripts/pr-touches-paths.py .github/workflows/wai-ops.yml \
"${{ github.event.pull_request.base.sha }}" \
"${{ github.event.pull_request.head.sha }}")
echo "this change touches wai-ops: $r"
echo "run=$r" >> "$GITHUB_OUTPUT"
native:
needs: relevant
if: needs.relevant.outputs.run == 'true'
name: ${{ matrix.label }}
runs-on: ${{ matrix.os }}
timeout-minutes: 40
strategy:
fail-fast: false
matrix:
include:
- { os: linux, label: linux-x86_64 }
- { os: linux-arm64, label: linux-aarch64 }
- { os: macos, label: macos-arm64 }
steps:
- uses: actions/checkout@v4
# The docker images ship no Rust; the macOS host has it, but launchd's PATH omits
# ~/.cargo/bin.
- name: Install Rust 1.99.1
shell: bash
run: |
export PATH="$HOME/.cargo/bin:$PATH"
command -v rustup >/dev/null 2>&1 || \
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile minimal --default-toolchain 1.99.1
rustup toolchain install 1.99.1 --profile minimal
rustup default 1.99.1
echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
- name: Unit, goldens, step-8, verdict and doc tests, debug
working-directory: wai/wai-ops
shell: bash
run: cargo test --locked
- name: Unit, goldens, step-8 and verdict tests, release
working-directory: wai/wai-ops
shell: bash
run: cargo test --locked --release
- name: Build wai-verify, and its own tests (the witness through the interpreter; --check's path)
working-directory: wai/wai-verify
shell: bash
run: |
set -euo pipefail
cargo build --locked --release --features cli --bin wai-verify
cargo test --locked --release --features cli --bin wai-verify
- name: Every vector file recomputed, every set re-lowered and certified, the corpus regenerated
working-directory: wai
shell: bash
run: wai-verify/target/release/wai-verify vectors verify .
# The exit status of `wai-verify bounds` (0: the verdict meets the profile, 1: it
# fails it, 3: a difference from the committed certificate), on the sets whose
# verdict integer-operators §14.3 and the design's predictions fix.
- name: The falsification sets fail their profile; committed sets meet theirs
working-directory: wai
shell: bash
run: |
set -euo pipefail
V=wai-verify/target/release/wai-verify
C=ops-conformance/certificates/wai.neural.int_synth
T="${RUNNER_TEMP:-/tmp}"
bounds() {
local want=$1; shift
set +e; "$V" bounds "$@" --out "$T/cert.json"; local got=$?; set -e
[ "$got" = "$want" ] || { echo "::error::wai-verify bounds $* exited $got, not $want"; exit 1; }
}
# One unit past i64 under acc64, and a claim of acc32 one weight past it.
bounds 1 ops-conformance/sets/overflow_acc64/int_synth.json --capability wai.neural.int_synth --profile acc64 \
--check $C/b35460f39f31a559e97e66b8dde4597a309cbc44199c40097f935dd8e6e7305a.json
bounds 1 ops-conformance/sets/claim_acc32/int_synth.json --capability wai.neural.int_synth --profile acc32 \
--check $C/76916c8f85da7663c09fba8cb091d628ed38328b680563285b8056cec82fd1ac.json
# facade meets acc32; photo meets acc64 and fails acc32 (at node 6, convT.acc).
bounds 0 neural-conformance/vectors/facade/int_synth.json --capability wai.neural.int_synth --profile acc32 \
--check $C/c6a362696d61605931ef4da98ae630362dcd73ea6be7864db6e61d6c5abbcd24.json
bounds 0 neural-conformance/vectors/photo/int_synth.json --capability wai.neural.int_synth --profile acc64 \
--check $C/50868e72f5f1599569c413ed1f67ab8610fa0b3c17919162cbf370f49275125c.json
# With --witness, a node-local graph for each failing node: photo's node 6, whose
# input attains convT.acc's upper end. With --advise, the clamps that would let
# the overflow set meet acc64.
bounds 1 neural-conformance/vectors/photo/int_synth.json --capability wai.neural.int_synth --profile acc32 \
--witness "$T/witness"
test -s "$T/witness/synth-6.json"
grep -q '"acc":"26172239136"' "$T/witness/synth-6.json"
bounds 1 ops-conformance/sets/overflow_acc64/int_synth.json --capability wai.neural.int_synth --advise acc64
# A certificate that is not the committed one is exit 3.
bounds 3 neural-conformance/vectors/photo/int_synth.json --capability wai.neural.int_synth \
--check $C/c6a362696d61605931ef4da98ae630362dcd73ea6be7864db6e61d6c5abbcd24.json
wasip2:
needs: relevant
if: needs.relevant.outputs.run == 'true'
name: wasm32-wasip2 (wasmtime)
runs-on: linux
timeout-minutes: 30
steps:
- uses: actions/checkout@v4
- name: Install Rust 1.99.1 with the wasm32-wasip2 target
shell: bash
run: |
export PATH="$HOME/.cargo/bin:$PATH"
command -v rustup >/dev/null 2>&1 || \
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile minimal --default-toolchain 1.99.1
rustup toolchain install 1.99.1 --profile minimal
rustup default 1.99.1
rustup target add wasm32-wasip2
echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
- name: Install wasmtime 38.0.3
shell: bash
run: |
set -euo pipefail
v=38.0.3
curl --proto '=https' --tlsv1.2 -sSfL -o "$RUNNER_TEMP/wasmtime.tar.xz" \
"https://github.com/bytecodealliance/wasmtime/releases/download/v$v/wasmtime-v$v-x86_64-linux.tar.xz"
tar -C "$RUNNER_TEMP" -xf "$RUNNER_TEMP/wasmtime.tar.xz"
echo "$RUNNER_TEMP/wasmtime-v$v-x86_64-linux" >> "$GITHUB_PATH"
# The tests read committed files through CARGO_MANIFEST_DIR/.., so the wai
# directory is preopened at its own absolute path.
- name: Unit, goldens, step-8 and verdict tests, under WASI
working-directory: wai/wai-ops
shell: bash
run: |
set -euo pipefail
W=$(cd .. && pwd)
CARGO_TARGET_WASM32_WASIP2_RUNNER="wasmtime run --dir $W::$W" \
cargo test --locked --release --target wasm32-wasip2
- name: Build wai-verify for wasm32-wasip2
working-directory: wai/wai-verify
shell: bash
run: cargo build --locked --release --features cli --target wasm32-wasip2 --bin wai-verify
- name: Every vector file recomputed, every set re-lowered and certified, the corpus regenerated, under WASI
working-directory: wai
shell: bash
run: |
set -euo pipefail
wasmtime --version
wasmtime run --dir .::/wai wai-verify/target/wasm32-wasip2/release/wai-verify.wasm vectors verify /wai
node:
needs: relevant
if: needs.relevant.outputs.run == 'true'
name: wasm32 under Node
runs-on: linux
timeout-minutes: 30
steps:
- uses: actions/checkout@v4
- name: Install Rust 1.99.1 with the wasm32 target
shell: bash
run: |
export PATH="$HOME/.cargo/bin:$PATH"
command -v rustup >/dev/null 2>&1 || \
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile minimal --default-toolchain 1.99.1
rustup toolchain install 1.99.1 --profile minimal
rustup default 1.99.1
rustup target add wasm32-unknown-unknown
echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
- uses: actions/setup-node@v4
with:
node-version: '22'
- name: Build the recomputation for wasm32-unknown-unknown
working-directory: wai/wai-ops/node
shell: bash
run: cargo build --locked --release --target wasm32-unknown-unknown
- name: Every vector file recomputed under Node
working-directory: wai/wai-ops/node
shell: bash
run: node verify.mjs target/wasm32-unknown-unknown/release/wai_ops_node.wasm ../../ops-conformance
checker:
needs: relevant
if: needs.relevant.outputs.run == 'true'
name: independent checker (Python)
runs-on: linux
timeout-minutes: 20
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.11'
# Standard library only, so it needs nothing installed.
- name: wai_ops_check.py rewrites every vector file, every lowered graph and every certificate
working-directory: wai
shell: bash
run: python3 -I tools/wai_ops_check.py ops-conformance
- name: Every workflow declares a concurrency group
shell: bash
run: bash scripts/check-workflow-concurrency.sh