Approved by the owner on 2026-10-22. Procedure: change `channel`, run `rustup show`, then run the pipeline. What changed - rust-toolchain.toml and eoc/eoc-rs/rust-toolchain.toml: channel "1.98.0" becomes "1.99.1". These are the only two pins in the tree, and the root one governs every other cargo root. - 64 workflows under .github/workflows (the forge's CI): every `Install Rust 1.98.0`, `rustup toolchain install / default / component add / target add --toolchain 1.98.0` and `--default-toolchain 1.98.0` now names 1.99.1 (409 lines). Two of those lines are in build steps rather than install steps (wai-conformance.yml's two `wasm32 (unix)` steps each `rustup target add --toolchain`), and they move with the rest: a target added to a toolchain that is not installed is an error. - Left as they are, because they record what was measured on 1.98.0: standards-build.yml's "Verified on a native arm64 Linux container (rustc 1.98.0)", wai-conformance.yml's note on Rust 1.98's LLD 22, and the "rustc 1.98.0 (example)" strings in receipts, vectors and docs. The one-codegen-unit workaround that note explains also stays. 1.99.1 ships LLD 23.1.1, which the note says links those inputs, but removing the workaround should wait for a run at the CI path on x86_64. Why - 1.98.0 has a P-critical miscompile, rust-lang/rust#161441 (I-miscompile, regression-from-stable-to-stable). rustc emits a vacant (null) method slot in a trait-object vtable, so a safe dynamic call jumps to address zero (undefined behaviour). RELEASES.md records the fix in 1.98.1 ("rustc: fix miscompilation in generating vtables"). - 1.99.1 is the current stable (channel manifest dated 2026-10-15; rustc 58cf8f9c3 2026-10-13). It also fixes 1.99.0's own regressions: wcslen on UEFI and embedded targets, x86_64 FFI `bool` returns, and the rust-lld rpath on macOS. Evidence All of it ran on the build host ([email protected], aarch64-apple-darwin) through ~/kani-logs/remote/rb. Nothing was built on the dev Mac. - `rustup show`: the active toolchain is 1.99.1-aarch64-apple-darwin, "overridden by .../rust-toolchain.toml" (and by eoc/eoc-rs's own file there). rustc 1.99.1 (58cf8f9c3 2026-10-13), LLVM 23.1.1, clippy 0.1.99, rustfmt 1.10.0. The baseline is rustc 1.98.0 (88d9e12ae 2026-08-18). - Scope: every cargo root the pin governs, which is 46 of the 49 tracked lockfiles. The other three: two are vendored crates that resolve inside their parents, and wai/wai-rs/fuzz builds on its own pinned nightly. - Trees. The final tree is main at96117c570plus these two commits. Main moved four times while this ran, and each root's evidence comes from the newest tree it was run on: - 13 roots on the final tree: every root main changed after1a465f23d, and every root that consumes such a crate by path. - 12 roots on1a465f23dplus these two commits. - 7 roots onb16816671plus these two commits. - 14 roots onaa61ab3b9plus the pin change. For each root in the last three groups, checked with git diff and the lockfiles' path packages: none of its files, and no crate it reaches by path, differs on the final tree. - Each root got: (a) `cargo fmt --all -- --check` on the pin and on 1.98.0. The output is byte-identical in all 46. CI gates no root on rustfmt, and none is rustfmt-clean on main. (b) `cargo clippy --locked --keep-going --workspace --all-targets` on both toolchains, with the diagnostics compared line by line. After the previous commit, no root has a diagnostic that only 1.99.1 reports. openpay's one differing line is the same lint at the same site, reworded. (c) `cargo test --workspace --locked`. (d) the root's other CI steps that can run on this host: feature-gated tests, conformance suites, release-profile tests, the aac page-set checks, and every clippy -D warnings gate. The gates are standards-build's macOS meter and omni lints (jouleclaw-energy x2, jouleclaw-omni metal, jouleclaw-loader-gguf, jcp, proof, eoc, sandbox), wai-pack, wai-quantum-cli (default, no-default and metal), wai-quantum-service, wai-quantum-qpu and wai-quantum-desktop. - Totals: `cargo test --workspace` ran in 43 roots: 12,532 passed, 1 failed, 101 ignored. The other 3 roots are wasm32-only, and their `cargo build --release --target wasm32-unknown-unknown` passed. Every other CI step passed (62 of 62). - On the final tree: scripts/check-lockfiles.sh (cargo 1.99.1) found all 47 lockfiles current, and scripts/check-advisories.py passes. - tokio is 1.54.1 in every lockfile cargo reads. That is patched for both RUSTSEC-2026-0386 (>= 1.53.3) and RUSTSEC-2026-0384 (>= 1.54.1). The 1.53.1 in vendor/wtransport/Cargo.lock is the upstream file kept with the vendored source; cargo resolves wtransport inside its parents, and both gates skip that file. - What is not green, each one reproduced on 1.98.0: - wai-ops-gpu: under the debug profile, `corpus` trips the debug_assert at exec.rs:187 on both toolchains. CI runs it in release only, and that passes (6/6). - wai-ops: clippy::derived_hash_with_manual_eq (deny-by-default) on both toolchains. No CI job runs clippy there. - wai-vector/wasm: `--all-targets` cannot build the lib-test target (its own `panic_impl`) on either toolchain. `clippy --lib` for wasm32 reports 0 diagnostics on both. - eoc-cascade's hit_calibration_process_energy test reads real energy counters, and it fails some of the time on the loaded shared host. In interleaved runs each toolchain passed 18 of 20. The full eoc-rs suite passed on the final tree (741 passed). - Environment, not code: - wai-quantum-desktop embeds the Studio's build, so wai/quantum-studio was built first (`npm ci`, `node build.mjs`), as CI does. - Not covered here: the x86_64 and arm64 Linux and Windows legs; the GPU, NPU, FPGA, emulator and hardware-meter legs; wasm32 tests under Node, wasmtime and wasip2; and the fuzz job. Co-Authored-By: Claude Opus 5.5 <[email protected]>
197 lines
9.2 KiB
YAML
197 lines
9.2 KiB
YAML
name: wai cross-architecture byte-equality
|
|
|
|
# The `replicate` determinism contract, checked on real silicon. WAI claims its
|
|
# integer-exact decode paths (rANS entropy coder, integer fixed-point synthesis)
|
|
# produce BYTE-IDENTICAL output on every machine. This matrix proves it: every
|
|
# OS/arch leg of the matrix below decodes the same fixtures and asserts the same golden
|
|
# bytes — rANS streams produced by CompressAI's upstream encoder, and an
|
|
# int_synth output hash produced on the reference machine (macOS arm64). One
|
|
# diverging byte anywhere fails the suite.
|
|
#
|
|
# Coverage is still-image AND temporal, classical AND learned: the rANS coder,
|
|
# integer fixed-point synthesis, the JPEG-AI entropy stage, the inter-frame video
|
|
# decoder (`wai.video.int_motion`), and the neural-keyframe variant
|
|
# (`wai.video.int_hyper`) whose I-frame comes out of a learned conditional codec,
|
|
# and the MLIC++-topology codec (`wai.neural.int_mlicpp`), whose entropy network runs
|
|
# before every checkerboard pass and must give every platform the encoder's scale
|
|
# bucket for every element. The learned integer audio and Gaussian-splat attribute codecs
|
|
# (`wai.audio.int_codec`, `wai.splat.int_codec`) decode their committed WIA1 and WIS1
|
|
# payloads to their PCM and attribute digests. The binary payloads SPEC §5 pins (WIV1,
|
|
# WIH1, WIA1, WIS1) are parsed
|
|
# with the wire parser a sink runs and decoded to the same digests, and the staged-delivery
|
|
# residual layers (WIR1) of the staged corpus are applied stage by stage to pinned digests.
|
|
# Video is the strictest leg — inter-frame decode is a
|
|
# feedback loop, so one divergent half-pel rounding does not stay one byte, it
|
|
# predicts the next frame and compounds for the rest of the clip.
|
|
#
|
|
# The conformance crate (`wai/byte-exact-conformance`) #[path]-includes the
|
|
# pure-integer sources from wai-rs — no system codec libraries, no ONNX runtime
|
|
# — so every leg runs in about a minute.
|
|
|
|
# One run per branch at a time. A push supersedes the run before it.
|
|
#
|
|
# There is one `macos` runner and it is the dev Mac, so every macOS job in this
|
|
# repo queues on it. With no concurrency group, a session pushing four versions
|
|
# of a branch queued four complete sets of runs and every one of them had to
|
|
# drain: on 2026-10-05 a PR's 21 contexts settled none in 70 minutes behind a
|
|
# backlog of 25 runs, and the queue grew faster than it cleared. Only the newest
|
|
# commit's verdict is wanted, so the older runs are cancelled.
|
|
#
|
|
# Verified on this forge (Forgejo 16.0.5) in `ci-test` before being added here:
|
|
# the key parses, and a newer push moves an older run to `cancelled` even while
|
|
# it is still queued, which is the case that matters.
|
|
#
|
|
# `cancel-in-progress: true` also applies to `main`. That is deliberate and
|
|
# safe here: main advances by merge commits whose tree contains the commits
|
|
# before them, so the newer run covers the older one's changes.
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
on:
|
|
pull_request:
|
|
paths:
|
|
- 'wai/byte-exact-conformance/**'
|
|
- 'wai/wai-rs/src/neural/int_synth.rs'
|
|
- 'wai/wai-rs/src/neural/jpegai_mans.rs'
|
|
# Every source the crate #[path]-includes must be able to fire this
|
|
# workflow, or a change can break cross-arch equality and merge green.
|
|
- 'wai/wai-rs/src/int_synth.rs'
|
|
- 'wai/wai-rs/src/int_entropy.rs'
|
|
- 'wai/wai-rs/src/jpegai_mans.rs'
|
|
- 'wai/wai-rs/src/rans.rs'
|
|
- 'wai/wai-rs/src/int_video.rs'
|
|
- 'wai/wai-rs/src/int_transform.rs'
|
|
- 'wai/wai-rs/src/int_hyper_synth.rs'
|
|
- 'wai/wai-rs/src/int_mlicpp.rs'
|
|
- 'wai/wai-rs/src/int_audio.rs'
|
|
- 'wai/wai-rs/src/int_splat.rs'
|
|
- 'wai/wai-rs/src/int_payload/wire.rs'
|
|
- 'wai/wai-rs/src/staged/predict.rs'
|
|
- 'wai/wai-rs/src/staged/wir1.rs'
|
|
- 'wai/wai-rs/src/staged/wir1_arith.rs'
|
|
- 'wai/staged-conformance/**'
|
|
# The fast kernels int_synth, int_transform and int_hyper_synth dispatch to
|
|
# by default: the goldens here decode through them.
|
|
- 'wai/wai-rs/src/int_kernels.rs'
|
|
# The integer operator set and the bridge to it: the goldens decode int_synth,
|
|
# the audio and splat codecs, the conditional codec (WIH1, the WIV1 keyframe)
|
|
# and the MLIC++-topology codec through their lowerings too.
|
|
- 'wai/wai-rs/src/int_ops.rs'
|
|
- 'wai/wai-ops/**'
|
|
- 'wai/wai-rs/tests/vectors/int_video/**'
|
|
- 'wai/wai-rs/tests/vectors/int_hyper/**'
|
|
- 'wai/wai-rs/tests/vectors/int_mlicpp/**'
|
|
- 'wai/wai-rs/tests/vectors/int_audio/**'
|
|
- 'wai/wai-rs/tests/vectors/int_splat/**'
|
|
- '.github/workflows/wai-byte-equality.yml'
|
|
push:
|
|
branches:
|
|
- main
|
|
paths:
|
|
- 'wai/byte-exact-conformance/**'
|
|
- 'wai/wai-rs/src/neural/int_synth.rs'
|
|
- 'wai/wai-rs/src/neural/jpegai_mans.rs'
|
|
# Every source the crate #[path]-includes must be able to fire this
|
|
# workflow, or a change can break cross-arch equality and merge green.
|
|
- 'wai/wai-rs/src/int_synth.rs'
|
|
- 'wai/wai-rs/src/int_entropy.rs'
|
|
- 'wai/wai-rs/src/jpegai_mans.rs'
|
|
- 'wai/wai-rs/src/rans.rs'
|
|
- 'wai/wai-rs/src/int_video.rs'
|
|
- 'wai/wai-rs/src/int_transform.rs'
|
|
- 'wai/wai-rs/src/int_hyper_synth.rs'
|
|
- 'wai/wai-rs/src/int_mlicpp.rs'
|
|
- 'wai/wai-rs/src/int_audio.rs'
|
|
- 'wai/wai-rs/src/int_splat.rs'
|
|
- 'wai/wai-rs/src/int_payload/wire.rs'
|
|
- 'wai/wai-rs/src/staged/predict.rs'
|
|
- 'wai/wai-rs/src/staged/wir1.rs'
|
|
- 'wai/wai-rs/src/staged/wir1_arith.rs'
|
|
- 'wai/staged-conformance/**'
|
|
# The fast kernels int_synth, int_transform and int_hyper_synth dispatch to
|
|
# by default: the goldens here decode through them.
|
|
- 'wai/wai-rs/src/int_kernels.rs'
|
|
# The integer operator set and the bridge to it: the goldens decode int_synth,
|
|
# the audio and splat codecs, the conditional codec (WIH1, the WIV1 keyframe)
|
|
# and the MLIC++-topology codec through their lowerings too.
|
|
- 'wai/wai-rs/src/int_ops.rs'
|
|
- 'wai/wai-ops/**'
|
|
- 'wai/wai-rs/tests/vectors/int_video/**'
|
|
- 'wai/wai-rs/tests/vectors/int_hyper/**'
|
|
- 'wai/wai-rs/tests/vectors/int_mlicpp/**'
|
|
- 'wai/wai-rs/tests/vectors/int_audio/**'
|
|
- 'wai/wai-rs/tests/vectors/int_splat/**'
|
|
- '.github/workflows/wai-byte-equality.yml'
|
|
|
|
jobs:
|
|
# Does this pull request's own diff touch the paths below? This forge matches a
|
|
# workflow's `paths:` against the push, so a merge of main into a branch fires the
|
|
# workflow whatever the pull request changes; every job here waits on this answer.
|
|
# A push to main, a schedule, or anything the script cannot determine answers
|
|
# `true` (scripts/pr-touches-paths.py).
|
|
relevant:
|
|
name: does this change touch it
|
|
runs-on: linux
|
|
outputs:
|
|
run: ${{ steps.gate.outputs.run }}
|
|
steps:
|
|
- uses: actions/checkout@v5
|
|
with:
|
|
fetch-depth: 0
|
|
- id: gate
|
|
run: |
|
|
set -euo pipefail
|
|
r=$(python3 scripts/pr-touches-paths.py .github/workflows/wai-byte-equality.yml \
|
|
"${{ github.event.pull_request.base.sha }}" \
|
|
"${{ github.event.pull_request.head.sha }}")
|
|
echo "this change touches wai-byte-equality: $r"
|
|
echo "run=$r" >> "$GITHUB_OUTPUT"
|
|
|
|
byte-equality:
|
|
needs: relevant
|
|
if: needs.relevant.outputs.run == 'true'
|
|
name: ${{ matrix.label }}
|
|
runs-on: ${{ matrix.os }}
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
# Self-hosted fleet labels, not hosted images. macos-x86_64 is
|
|
# dropped: no Intel-Mac runner exists in the fleet, and by the same
|
|
# argument the cargo-classes matrix already makes, it adds no arch
|
|
# coverage — x86_64 is held by linux-x86_64, arm64 by linux-aarch64
|
|
# and the macos-arm64 reference.
|
|
# Windows x86_64 leg removed 2026-09-30: runner offline. Restore by
|
|
# re-adding `- { os: windows, label: windows-x86_64 }` here once the
|
|
# runner is back online.
|
|
include:
|
|
- { os: linux, label: linux-x86_64 }
|
|
- { os: linux-arm64, label: linux-aarch64 }
|
|
- { os: macos, label: macos-arm64 (reference) }
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
|
|
# unix: bootstrap rustup (docker image ships no Rust; macOS host has it but
|
|
# launchd's PATH omits ~/.cargo/bin). Windows is a host executor with rustup
|
|
# already present, and must use pwsh — its `bash` is the WSL stub.
|
|
- name: Install Rust 1.99.1 (unix)
|
|
if: matrix.os != 'windows'
|
|
shell: bash
|
|
run: |
|
|
export PATH="$HOME/.cargo/bin:$PATH"
|
|
command -v rustup >/dev/null 2>&1 || \
|
|
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile minimal --default-toolchain 1.99.1
|
|
rustup toolchain install 1.99.1 --profile minimal
|
|
rustup default 1.99.1
|
|
echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
|
|
- name: Install Rust 1.99.1 (Windows)
|
|
if: matrix.os == 'windows'
|
|
shell: pwsh
|
|
run: |
|
|
rustup toolchain install 1.99.1 --profile minimal
|
|
rustup default 1.99.1
|
|
|
|
- name: Decode fixtures, assert golden bytes
|
|
working-directory: wai/byte-exact-conformance
|
|
run: cargo test --release -- --nocapture
|