Transaction-Science/open-standards
Watch
1
0
Fork
You've already forked open-standards
 0
Code Issues Pull requests Projects Releases 15 Packages Wiki Activity Actions 156
open-standards/.github/workflows/wai-studio.yml
Transaction Science ec45aaaca9 toolchain: Rust 1.98.0 -> 1.99.1 (change-controlled pin) 
Approved by the owner on 2026-10-22. Procedure: change `channel`, run
`rustup show`, then run the pipeline.

What changed
- rust-toolchain.toml and eoc/eoc-rs/rust-toolchain.toml: channel "1.98.0"
  becomes "1.99.1". These are the only two pins in the tree, and the root one
  governs every other cargo root.
- 64 workflows under .github/workflows (the forge's CI): every `Install Rust
  1.98.0`, `rustup toolchain install / default / component add / target add
  --toolchain 1.98.0` and `--default-toolchain 1.98.0` now names 1.99.1
  (409 lines). Two of those lines are in build steps rather than install
  steps (wai-conformance.yml's two `wasm32 (unix)` steps each
  `rustup target add --toolchain`), and they move with the rest: a target
  added to a toolchain that is not installed is an error.
- Left as they are, because they record what was measured on 1.98.0:
  standards-build.yml's "Verified on a native arm64 Linux container (rustc
  1.98.0)", wai-conformance.yml's note on Rust 1.98's LLD 22, and the
  "rustc 1.98.0 (example)" strings in receipts, vectors and docs. The
  one-codegen-unit workaround that note explains also stays. 1.99.1 ships
  LLD 23.1.1, which the note says links those inputs, but removing the
  workaround should wait for a run at the CI path on x86_64.

Why
- 1.98.0 has a P-critical miscompile, rust-lang/rust#161441 (I-miscompile,
  regression-from-stable-to-stable). rustc emits a vacant (null) method slot
  in a trait-object vtable, so a safe dynamic call jumps to address zero
  (undefined behaviour). RELEASES.md records the fix in 1.98.1 ("rustc: fix
  miscompilation in generating vtables").
- 1.99.1 is the current stable (channel manifest dated 2026-10-15; rustc
  58cf8f9c3 2026-10-13). It also fixes 1.99.0's own regressions: wcslen on
  UEFI and embedded targets, x86_64 FFI `bool` returns, and the rust-lld rpath
  on macOS.

Evidence
All of it ran on the build host ([email protected], aarch64-apple-darwin)
through ~/kani-logs/remote/rb. Nothing was built on the dev Mac.

- `rustup show`: the active toolchain is 1.99.1-aarch64-apple-darwin,
  "overridden by .../rust-toolchain.toml" (and by eoc/eoc-rs's own file
  there). rustc 1.99.1 (58cf8f9c3 2026-10-13), LLVM 23.1.1, clippy 0.1.99,
  rustfmt 1.10.0. The baseline is rustc 1.98.0 (88d9e12ae 2026-08-18).
- Scope: every cargo root the pin governs, which is 46 of the 49 tracked
  lockfiles. The other three: two are vendored crates that resolve inside
  their parents, and wai/wai-rs/fuzz builds on its own pinned nightly.
- Trees. The final tree is main at 96117c570 plus these two commits. Main
  moved four times while this ran, and each root's evidence comes from the
  newest tree it was run on:
  - 13 roots on the final tree: every root main changed after 1a465f23d,
    and every root that consumes such a crate by path.
  - 12 roots on 1a465f23d plus these two commits.
  - 7 roots on b16816671 plus these two commits.
  - 14 roots on aa61ab3b9 plus the pin change.
  For each root in the last three groups, checked with git diff and the
  lockfiles' path packages: none of its files, and no crate it reaches by
  path, differs on the final tree.
- Each root got:
  (a) `cargo fmt --all -- --check` on the pin and on 1.98.0. The output is
      byte-identical in all 46. CI gates no root on rustfmt, and none is
      rustfmt-clean on main.
  (b) `cargo clippy --locked --keep-going --workspace --all-targets` on both
      toolchains, with the diagnostics compared line by line. After the
      previous commit, no root has a diagnostic that only 1.99.1 reports.
      openpay's one differing line is the same lint at the same site,
      reworded.
  (c) `cargo test --workspace --locked`.
  (d) the root's other CI steps that can run on this host: feature-gated
      tests, conformance suites, release-profile tests, the aac page-set
      checks, and every clippy -D warnings gate. The gates are
      standards-build's macOS meter and omni lints (jouleclaw-energy x2,
      jouleclaw-omni metal, jouleclaw-loader-gguf, jcp, proof, eoc, sandbox),
      wai-pack, wai-quantum-cli (default, no-default and metal),
      wai-quantum-service, wai-quantum-qpu and wai-quantum-desktop.
- Totals: `cargo test --workspace` ran in 43 roots: 12,532 passed, 1 failed,
  101 ignored. The other 3 roots are wasm32-only, and their
  `cargo build --release --target wasm32-unknown-unknown` passed. Every
  other CI step passed (62 of 62).
- On the final tree: scripts/check-lockfiles.sh (cargo 1.99.1) found all 47
  lockfiles current, and scripts/check-advisories.py passes.
- tokio is 1.54.1 in every lockfile cargo reads. That is patched for both
  RUSTSEC-2026-0386 (>= 1.53.3) and RUSTSEC-2026-0384 (>= 1.54.1). The 1.53.1
  in vendor/wtransport/Cargo.lock is the upstream file kept with the vendored
  source; cargo resolves wtransport inside its parents, and both gates skip
  that file.
- What is not green, each one reproduced on 1.98.0:
  - wai-ops-gpu: under the debug profile, `corpus` trips the debug_assert at
    exec.rs:187 on both toolchains. CI runs it in release only, and that
    passes (6/6).
  - wai-ops: clippy::derived_hash_with_manual_eq (deny-by-default) on both
    toolchains. No CI job runs clippy there.
  - wai-vector/wasm: `--all-targets` cannot build the lib-test target (its
    own `panic_impl`) on either toolchain. `clippy --lib` for wasm32 reports
    0 diagnostics on both.
  - eoc-cascade's hit_calibration_process_energy test reads real energy
    counters, and it fails some of the time on the loaded shared host. In
    interleaved runs each toolchain passed 18 of 20. The full eoc-rs suite
    passed on the final tree (741 passed).
- Environment, not code:
  - wai-quantum-desktop embeds the Studio's build, so wai/quantum-studio was
    built first (`npm ci`, `node build.mjs`), as CI does.
- Not covered here: the x86_64 and arm64 Linux and Windows legs; the GPU,
  NPU, FPGA, emulator and hardware-meter legs; wasm32 tests under Node,
  wasmtime and wasip2; and the fuzz job.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-11-03 17:42:20 -05:00

190 lines
8.2 KiB
YAML
Raw Permalink Blame History

name: WAI Studio
# WAI Studio on the web (wai/wai-studio): one front end, its core in WebAssembly, served by
# `wai dev` at /_wai/ and hosted by the WAI site.
#
# - catalogue · linux: Studio's actions hold to the operation catalogue (scripts/actions.mjs
# --check: an action with no operation, an operation placed for the browser with no action,
# a mismatched name), the unit tests that need no core build (the generation and every rule
# of the drift check broken in a copy, the palette, the local core's calls), and the core's
# own tests and clippy (core/, wai-studio-core, on the http-conformance vectors);
# - browser · macos: e2e/run.sh builds wai, the relay, the room service, the core, the room
# client's packages, the quantum engine, Quantum Studio and Studio; runs every unit test,
# the core's calls among them, and the drift check; then e2e/studio.e2e.mjs against a
# `wai dev` stack in Chromium and Firefox: each panel on both hosts, Inspect and Verify on
# conformance vectors with the results their cases expect, a room joined as a viewer, the
# palette, axe (WCAG 2.2 A and AA), no console error or failed request;
# - webkit · linux: the same in WebKit, in the browser image of the Playwright release
# package-lock.json pins (by digest). The macOS runner is started from SSH, and a process of
# an SSH session there cannot open WebKit's helper processes: WebKit never launches.
#
# `wai dev`'s side (/_wai/ on its origin, nothing listening beyond loopback) is tested in the
# WAI conformance workflow's quickstart step (tests/cli_studio.rs and the binary's own tests).
#
# Push filters match the push's delta, so every path Studio builds on is listed.
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
on:
push:
branches: [main]
paths:
- 'wai/wai-studio/**'
- 'wai/wai-rs/**'
- 'wai/catalogue/**'
- 'wai/quantum-studio/**'
- 'wai/wai-web/**'
- 'wai/wai-quantum/**'
- 'wai/wai-ops/**'
- 'wai/wai-live-web/**'
- 'wai/quickstart/build-web.sh'
- 'wai/http-conformance/**'
- 'wai/pack-conformance/stills/**'
- 'joule-code/joule-code-rs/crates/joule-moq-web/**'
- 'joule-code/joule-code-rs/crates/joule-moq-relay/**'
- 'joule-code/joule-code-rs/crates/joule-moq-room/**'
- 'rust-toolchain.toml'
- '.github/workflows/wai-studio.yml'
pull_request:
paths:
- 'wai/wai-studio/**'
- 'wai/wai-rs/**'
- 'wai/catalogue/**'
- 'wai/quantum-studio/**'
- 'wai/wai-web/**'
- 'wai/wai-quantum/**'
- 'wai/wai-ops/**'
- 'wai/wai-live-web/**'
- 'wai/quickstart/build-web.sh'
- 'wai/http-conformance/**'
- 'wai/pack-conformance/stills/**'
- 'joule-code/joule-code-rs/crates/joule-moq-web/**'
- 'joule-code/joule-code-rs/crates/joule-moq-relay/**'
- 'joule-code/joule-code-rs/crates/joule-moq-room/**'
- 'rust-toolchain.toml'
- '.github/workflows/wai-studio.yml'
jobs:
# The path filters gate the trigger; this job gates the work from the pull request's own
# diff (scripts/pr-touches-paths.py, reading the list above), as wai-pack.yml explains.
relevant:
name: does this change touch it
runs-on: linux
outputs:
run: ${{ steps.gate.outputs.run }}
steps:
- uses: actions/checkout@v5
with:
fetch-depth: 0
- id: gate
run: |
set -euo pipefail
r=$(python3 scripts/pr-touches-paths.py .github/workflows/wai-studio.yml \
"${{ github.event.pull_request.base.sha }}" \
"${{ github.event.pull_request.head.sha }}")
echo "this change touches WAI Studio: $r"
echo "run=$r" >> "$GITHUB_OUTPUT"
catalogue:
name: the catalogue's actions, the unit tests and the core · linux
needs: relevant
if: needs.relevant.outputs.run == 'true'
runs-on: linux
timeout-minutes: 60
steps:
- uses: actions/checkout@v5
- name: Install Rust 1.99.1
shell: bash
run: |
export PATH="$HOME/.cargo/bin:$PATH"
command -v rustup >/dev/null 2>&1 || \
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile minimal --default-toolchain 1.99.1
rustup toolchain install 1.99.1 --profile minimal --component clippy
rustup default 1.99.1
echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
- uses: actions/setup-node@v4
with:
node-version: '22'
- name: Studio's actions hold to the catalogue
working-directory: wai/wai-studio
run: node scripts/actions.mjs --check
# The core's calls (test/core.test.mjs) need the core built for the web; the browser
# job runs them. These need nothing built.
- name: Unit tests
shell: bash
working-directory: wai/wai-studio
run: |
set -euo pipefail
node --test --test-reporter=tap test/actions.test.mjs test/palette.test.mjs test/local-core.test.mjs 2>&1 | tee "$RUNNER_TEMP/unit.log"
grep -qE '^# pass [1-9]' "$RUNNER_TEMP/unit.log" && grep -qE '^# fail 0$' "$RUNNER_TEMP/unit.log" || { echo "::error::no unit test ran, or one failed"; exit 1; }
- name: The core's tests and clippy
shell: bash
working-directory: wai/wai-studio/core
run: |
set -euo pipefail
cargo test --locked 2>&1 | tee "$RUNNER_TEMP/core.log"
grep -qE '^test result: ok\. [1-9][0-9]* passed; 0 failed' "$RUNNER_TEMP/core.log" || { echo "::error::no test ran"; exit 1; }
cargo clippy --locked --all-targets -- -D warnings
browser:
name: Studio in Chromium and Firefox · macos
needs: relevant
if: needs.relevant.outputs.run == 'true'
runs-on: macos
timeout-minutes: 120
steps:
- uses: actions/checkout@v5
# launchd's PATH omits cargo and node on the macOS host runner.
- name: Put cargo and node on PATH
shell: bash
run: |
echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
echo "/opt/homebrew/bin" >> "$GITHUB_PATH"
- name: wasm32 target and wasm-bindgen CLI 0.2.127
shell: bash
run: |
rustup target add wasm32-unknown-unknown
command -v wasm-bindgen >/dev/null && wasm-bindgen --version | grep -q ' 0\.2\.127$' || cargo install --locked wasm-bindgen-cli --version 0.2.127
- name: The browsers Playwright drives
shell: bash
working-directory: wai/wai-studio
run: |
set -euo pipefail
npm ci --ignore-scripts --no-audit --no-fund
npx playwright install chromium firefox
- name: Build everything, the unit tests, the drift check, and Studio in Chromium and Firefox
shell: bash
env:
STUDIO_OUT: ${{ runner.temp }}/wai-studio-e2e
run: nice -n 10 bash wai/wai-studio/e2e/run.sh --browsers chromium,firefox
webkit:
name: Studio in WebKit · linux
needs: relevant
if: needs.relevant.outputs.run == 'true'
runs-on: linux
timeout-minutes: 150
# Playwright 1.60.0's image (package-lock.json pins 1.60.0): Node, and WebKit with every
# library it needs.
container:
image: mcr.microsoft.com/playwright@sha256:9bd26ad900bb5e0f4dee75839e957a89ae89c2b7ab1e76050e559790e946b948
steps:
- uses: actions/checkout@v5
# The floor's zstd is C, compiled for wasm32 by clang and archived by llvm-ar.
- name: Rust 1.99.1 with the wasm32 target, clang and llvm, wasm-bindgen CLI 0.2.127
shell: bash
run: |
set -euo pipefail
apt-get update -qq
apt-get install -y -qq --no-install-recommends curl ca-certificates build-essential pkg-config clang llvm python3 git > /dev/null
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile minimal --default-toolchain 1.99.1
"$HOME/.cargo/bin/rustup" target add wasm32-unknown-unknown
"$HOME/.cargo/bin/cargo" install --locked wasm-bindgen-cli --version 0.2.127
echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
- name: Build everything, the unit tests, the drift check, and Studio in WebKit
shell: bash
env:
STUDIO_OUT: ${{ runner.temp }}/wai-studio-e2e
run: bash wai/wai-studio/e2e/run.sh --browsers webkit
Reference in a new issue View git blame Copy permalink