Some checks failed
wai cross-architecture byte-equality / macos-arm64 (reference) (pull_request) Failing after 3s
wai cross-architecture byte-equality / linux-aarch64 (pull_request) Failing after 4s
wai cross-architecture byte-equality / windows-x86_64 (pull_request) Failing after 16s
WAI conformance / cargo-class corpora · windows (pull_request) Failing after 10s
WAI conformance / cross-arch byte-equality · windows (pull_request) Failing after 9s
WAI conformance / cargo-class corpora · linux-arm64 (pull_request) Successful in 51s
WAI conformance / cross-arch byte-equality · linux-arm64 (pull_request) Failing after 18s
joule-code conformance gate / Build + round-trip C1-C4 vectors (pull_request) Failing after 1m31s
WAI conformance / cargo-class corpora · macos (pull_request) Successful in 2m27s
jouleclaw public surface must stay documented / Public-surface audit (jouleclaw-rs) (pull_request) Successful in 59s
wai cross-architecture byte-equality / linux-x86_64 (pull_request) Failing after 14s
WAI conformance / cross-arch byte-equality · macos (pull_request) Failing after 19s
WAI conformance / cargo-class corpora · linux (pull_request) Successful in 30s
WAI conformance / cross-arch byte-equality · linux (pull_request) Failing after 14s
WAI neural decoders end-to-end / synthetic fixtures → Rust decode → reference (±4) (pull_request) Failing after 1m6s
First real CI run after enabling Actions went 14/19 red. Root cause, run
down rather than guessed: the docker-executor runners (linux, linux-arm64,
windows) use `catthehacker/ubuntu:act-22.04`, which carries node/curl/git
but no Rust — `docker run … which cargo rustc rustup` returns nothing. The
`macos` runner is a *host* executor on the dev box where cargo exists,
which is exactly why the same `cargo-class corpora` job was green on macos
and red on every other arch.
Both Rust-setup styles in the repo assumed a compiler was already present:
- raw `rustup toolchain install …` (wai-conformance, wai-neural-e2e)
- `dtolnay/rust-toolchain` (wai-byte-equality, jouleclaw-public-surface,
joule-code-conformance) — which is *not* a fix here: the action itself
shells out to `rustup`, so it fails identically on an image without it.
wai-byte-equality already used dtolnay and failed the same way; that is
what ruled the action out.
Every Rust job now bootstraps rustup itself, which works on both executor
kinds: on the docker image it installs via rustup-init; on the macOS host
it finds the existing rustup once ~/.cargo/bin is on PATH (launchd's PATH
omits it). Proven in the actual runner image before writing it —
`docker run catthehacker/ubuntu:act-22.04` + rustup-init installed 1.97.1
and compiled a binary clean.
Scope: this fixes the *toolchain* step for all six Rust jobs. Jobs with
further environment needs (wai-neural-e2e pulls a CPU torch + onnxruntime
stack) may surface their own next failure — that is the following layer,
not this one. The PR's own CI run is the verification.
Co-Authored-By: Claude Opus 4.8 <[email protected]>
67 lines
2.7 KiB
YAML
67 lines
2.7 KiB
YAML
name: jouleclaw public surface must stay documented
|
|
|
|
# Regression-prevention gate for jouleclaw-rs. The brownfield
|
|
# onramp (`cargo run -p jouleclaw-brownfield --example
|
|
# scan_self`) walks every crate, infers reasons for every
|
|
# public function (docs / name pattern / error-handling
|
|
# signal), and reports those whose best-available reason is
|
|
# Lost. After the 219 → 0 curation pass that closed the
|
|
# initial baseline, every new `pub fn` is expected to ship
|
|
# with the same minimal `///` doc, OR be downgraded to
|
|
# `pub(crate)` if it isn't part of the consumer-visible
|
|
# surface. The `--fail-on-lost` flag exits non-zero when any
|
|
# public-surface Lost reason remains, so this workflow is a
|
|
# permanent safety net against drift.
|
|
|
|
on:
|
|
pull_request:
|
|
paths:
|
|
- 'jouleclaw/jouleclaw-rs/**'
|
|
- '.github/workflows/jouleclaw-public-surface-documented.yml'
|
|
push:
|
|
branches:
|
|
- main
|
|
paths:
|
|
- 'jouleclaw/jouleclaw-rs/**'
|
|
- '.github/workflows/jouleclaw-public-surface-documented.yml'
|
|
|
|
jobs:
|
|
scan:
|
|
name: Public-surface audit (jouleclaw-rs)
|
|
runs-on: linux
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
|
|
# Bootstrap rustup: the docker runner image ships no Rust, and
|
|
# dtolnay/rust-toolchain cannot help — it calls `rustup`, which is absent.
|
|
- name: Install Rust 1.97.1
|
|
run: |
|
|
export PATH="$HOME/.cargo/bin:$PATH"
|
|
command -v rustup >/dev/null 2>&1 || \
|
|
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile minimal --default-toolchain 1.97.1
|
|
rustup toolchain install 1.97.1 --profile minimal
|
|
rustup default 1.97.1
|
|
echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
|
|
|
|
- name: Cache cargo registry + target
|
|
uses: actions/cache@v4
|
|
with:
|
|
path: |
|
|
~/.cargo/registry
|
|
~/.cargo/git
|
|
jouleclaw/jouleclaw-rs/target
|
|
key: ${{ runner.os }}-cargo-brownfield-${{ hashFiles('jouleclaw/jouleclaw-rs/Cargo.lock') }}
|
|
restore-keys: |
|
|
${{ runner.os }}-cargo-brownfield-
|
|
|
|
- name: Run brownfield self-scan with --fail-on-lost
|
|
working-directory: jouleclaw/jouleclaw-rs
|
|
run: |
|
|
set -euo pipefail
|
|
if ! cargo run -q -p jouleclaw-brownfield --example scan_self -- --fail-on-lost; then
|
|
echo "::error::Public-surface Lost > 0 — jouleclaw-rs has undocumented public functions."
|
|
echo "::error::Fix by adding a `///` doc comment above each flagged `pub fn`, OR by downgrading to `pub(crate)` if it isn't consumer-visible."
|
|
echo "::error::Run locally with: cargo run -p jouleclaw-brownfield --example scan_self"
|
|
exit 1
|
|
fi
|