Round 3 of the package review.
A. §3.2: an override only forces royalty_free_only on. Overrides.royalty_free_only is a
bool (force on); Policy::effective ORs it in. Both verifiers read policy.json's
royalty_free_only as that override, so a policy.json of false over a policy.toml of
true is policy-json-mismatch. pack_verify.py parses policy.toml, applies the
override, then checks §3.6 under the effective policy (§11.3 step 4), no longer
refusing at the parse. Corpus case policy-json-relaxes-royalty-free (the review's
pk-pol-rfo-false: a patent-pool floor relabelled through the objects and index,
sealed with policy.json false). golden::reseal_as seals a policy.json given as bytes.
The policy corpus's override case is now eq-defaults-a.toml forced on (example.toml
forced off was a relaxation); packs.rs takes the line out of the policy instead.
B. pack_verify.py's strict walk raises on a directory it cannot read (os.walk onerror)
and refuses it, as read_strict does.
C. Both verifiers refuse a directory below the package that holds nothing
(unexpected-file); §11.1 says "no other file or directory". Corpus cases
empty-directory, empty-dot-directory (.git/refs) and unreadable-directory (mode 0,
or empty where the platform has no modes). Package cases are now written out and
verified as directories by both verifiers (golden::package_case_verdict).
D. wai-pack pack refuses an --out that exists and is not empty (pack-out-not-empty,
pack::out_dir_ready), before any work; §11.4 and §12. refusals.rs runs the command
line: a stale claim left alone, a file in the way, an empty and a new directory
packed and verified.
E. A class named classic in any case is pack-id (eq_ignore_ascii_case); corpus case
class-named-classic-in-capitals.
F. review.rs deep_alterations_never_panic: 300 seeded rounds of floor-unit, framing,
base-payload and index-field alterations through golden::replace_object and a
re-seal; never a panic; anything accepted is in a stated equivalence class (AV1
frame data, producer statements, equivalent WIV1 encodings) or the golden itself.
Floors: review 9, refusals 5.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
39375763c7