Exact

Exact Union RegExp

Repository files (latest commit first)

Filename	Latest commit message	Latest commit date
Transaction Science 980db9acad jcp-efficiency: an undefined ratio is not zero ... `uj_per_accepted_token()` is the crate's headline figure, and it read self.energy.uj().checked_div(self.tokens_out).unwrap_or(0) For a cost-per-result metric 0 is the *optimum*, so "the denominator was zero" (uncomputable) was reported as "this cost nothing per token" (perfect, and better than any successful run). It is not a convenience accessor: `wire()` seals it into the signed core, and `verify()` reads it straight back out rather than recomputing it, so the conflation was sealed and consumed as the headline. The case is the crate's own documented one. `completed: false` is documented as meaning "the tokens/joules below bought nothing" — exactly when `tokens_out` is 0 and the sealed figure became 0. A unit that burned 10 J and accepted nothing sealed `{"completed":0,"tokens_out":0,"energy_uj":10000000, "uj_per_accepted_token":0}`, signed: indistinguishable to a dashboard or an auditor from a run that used no energy. The family already specifies the right shape, and this crate's doc comment claimed to match it ("matching the family's `uj_per_accepted_token` convention") while doing the opposite. `mesh/SPEC.md` §6 says the figure is "omitted when no tokens were accepted", `mesh/SPEC.md` §8 says it "is undefined when no tokens were accepted", and `MeshReceipt::uj_per_accepted_token` returns `Option<u64>` and omits the key from its sealed wire, with tests pinning both branches. The fix brings jcp-efficiency onto that shape. Changed, because the zero they returned is each figure's *optimum*: - `Efficiency::uj_per_accepted_token` -> `Option<u64>`; omitted from the sealed core when undefined. `EfficiencyReceipt`'s field becomes `Option<u64>` and `verify()` reads it as optional, so an older receipt that carries the figure still round-trips. - `uusd_per_accepted_token` already returned `Option` because "a value figure is never invented" — but `wire()` sealed `.unwrap_or(0)`, inventing one. It now flattens with `and_then` and the key is omitted. `value_uusd` is an input and still seals. - `Totals::tokens_per_completed_unit` and `uj_per_completed_unit` -> `Option<u64>`. The first claims to "charge every attempt against the results actually delivered", which it stops doing precisely when nothing was delivered: 50 units and 500 J of spend reported 0 cost per completed unit. - `Totals::waste_fraction` -> `Option<f64>`: 0.0 is a perfect zero-waste record, which is what an empty ledger used to report. Deliberately unchanged: `value_per_joule` and `tokens_per_sec` keep their `0.0`. Higher is better for both, so the fallback is their worst value, not their optimum — a zero that understates is not this defect. `a_fallback_toward_the_worst_value_is_left_alone` pins that choice. `examples/session.rs` renders an undefined figure as "—" rather than a number, which also makes the distinction visible in the demo it prints. Co-Authored-By: Claude Opus 5 <[email protected]>		2026-10-17 04:49:02 -04:00
..
session.rs	jcp-efficiency: an undefined ratio is not zero	2026-10-17 04:49:02 -04:00