| Filename | Latest commit message | Latest commit date |
|---|---|---|
bdeccb7403
Some checks failed
jouleclaw fabrics / cuda (linux, RTX 4050 + Vulkan loader) (pull_request) Successful in 18s
jouleclaw fabrics / vulkan (linux, RTX 4050 + Vulkan loader) (pull_request) Successful in 18s
standards workspaces build + test / which workspaces this change touches (pull_request) Successful in 5s
repository checks / lockfiles, tests in CI, workflow hygiene, spec and section references, public text (pull_request) Successful in 43s
standards workspaces build + test / jouleclaw-rs (-nodebug, jouleclaw/jouleclaw-rs, -p jouleclaw-energy --features rapl,nvml, jouleclaw-rs, linux-arm64, -C target-feature=+fp16) (pull_request) Successful in 2m25s
standards workspaces build + test / joule-code-rs (joule-code/joule-code-rs, joule-code-rs, linux-arm64, true) (pull_request) Successful in 2m4s
standards workspaces build + test / joulecontract-rs (joulecontract/joulecontract-rs, joulecontract-rs, linux-arm64, true) (pull_request) Successful in 55s
standards workspaces build + test / map-rs (map-conformance, map/map-rs, map-rs, linux-arm64) (pull_request) Successful in 58s
standards workspaces build + test / aac-rs (aac-conformance, aac/aac-rs, aac-rs, linux-arm64) (pull_request) Successful in 3m17s
standards workspaces build + test / mesh-rs (mesh/mesh-rs, -p mesh-engine-gguf -p mesh-openai --features mesh-engine-gguf/gguf,mesh-openai/server, mesh-rs, linux-arm64) (pull_request) Successful in 56s
standards workspaces build + test / openpay (openpay, openpay, linux-arm64) (pull_request) Successful in 3m19s
jouleclaw fabrics / metal (macOS, Apple GPU) (pull_request) Successful in 42s
jouleclaw public surface must stay documented / Public-surface audit (jouleclaw-rs) (pull_request) Successful in 59s
standards workspaces build + test / macOS energy backends (pull_request) Failing after 3m58s
standards workspaces build + test / jouledesk-rs (jouledesk/jouledesk-rs, jouledesk-rs, macos) (pull_request) Successful in 2m37s
standards workspaces build + test / arl-rs (arl/arl-rs, arl-rs, linux) (pull_request) Successful in 1m9s
standards workspaces build + test / eoc-rs (eoc/eoc-rs, -p eoc-meter --features cuda, eoc-rs, linux) (pull_request) Successful in 2m7s
standards workspaces build + test / jcp-rs (jcp-conformance, jcp/jcp-rs, -p jcp-energy --features nvml, jcp-rs, linux) (pull_request) Successful in 1m42s
standards workspaces build + test / joule-ui-rs (joule-ui/joule-ui-rs, joule-ui-rs, linux) (pull_request) Successful in 1m13s
standards workspaces build + test / joulehook-rs (joulehook/joulehook-rs, joulehook-rs, linux) (pull_request) Successful in 1m13s
standards workspaces build + test / proof-rs (proof-conformance, proof/proof-rs, proof-rs, linux, true) (pull_request) Successful in 1m36s
standards workspaces build + test / sandbox-rs (sandbox-conformance, sandbox/sandbox-rs, sandbox-rs, linux) (pull_request) Successful in 2m23s
standards workspaces build + test / sense-rs (sense/sense-rs, sense-rs, linux) (pull_request) Successful in 1m14s
standards workspaces build + test / smart-byte-rs (smart-byte/smart-byte-rs, smart-byte-rs, linux) (pull_request) Successful in 4m10s
10983 -> 0, and `jouleclaw-omni --features metal` joins the `-D warnings`
clippy step in standards-build.yml, so it cannot regress. The pinned
ratchet added earlier is deleted: a denial is strictly stronger than a
count that may not rise.
The honest accounting, because "zero" is doing some work in that sentence:
6774 fixed by `cargo clippy --fix` (earlier commit)
3896 allowed as crate policy, grouped with reasons (earlier commit)
282 allowed here, grouped with reasons
~31 fixed here
Of the ~31 fixed here, three were defects rather than style:
- the GPT-2 BPE pre-tokenizer regex, which never compiled (its own commit)
- `unet.rs` computed a kernel-size heuristic and shadowed it on the very
next line, so the first was dead; and a `to_q/to_k/to_v` branch returned
the same `cin` as the arm below it
- a `///` block documenting nothing
The rest were mechanical: checked_div for guarded divisions, clone_from,
an `#[ignore]` given its reason, 6.28 -> TAU, 0.6931472 -> LN_2.
Two allows are soundness notes, not style, and say so at the attribute:
- `cast_ptr_alignment` (8): these cast mmap'd GGUF bytes to f32/u16
slices. GGUF aligns tensor data, so they are aligned in practice, but
that is a file-format invariant the type system is not carrying.
bytemuck::try_cast_slice would check it.
- `mut_from_ref` (1): `as_mut_slice(&self)` hands out a `&mut` from a
`&`. It is unsafe and the caller carries aliasing, but the signature
invites misuse.
One allow is a correctness argument against the lint: `manual_clamp`.
`x.min(hi).max(lo)` is not `x.clamp(lo, hi)` for floats, because
`f32::min` returns the non-NaN operand -- the chain scrubs NaN while
clamp propagates it. Taking clippy's advice would let a NaN timestep
through a diffusion schedule.
Verified after every edit, not at the end: 0 errors, 44/44 shaders,
26/26 Metal kernel tests on a GPU, 44 omni tests, 343 loader-gguf tests,
and `clippy -- -D warnings` exits 0.
Co-Authored-By: Claude Opus 5 <[email protected]>
|
||
| .. | ||
| check-comparative-prose.sh | ||
| check-fabric-errors.py | ||
| check-lockfiles-selftest.sh | ||
| check-lockfiles.sh | ||
| check-metal-shaders.py | ||
| check-no-vanity-metrics.sh | ||
| check-orphan-sources.py | ||
| check-public-names.sh | ||
| check-spec-refs-selftest.sh | ||
| check-spec-refs.py | ||
| check-tests-in-ci-selftest.sh | ||
| check-tests-in-ci.py | ||
| check-wai-section-refs.py | ||
| check-workflow-concurrency-selftest.sh | ||
| check-workflow-concurrency.sh | ||
| install-hooks.sh | ||
| pr-touches-paths-selftest.sh | ||
| pr-touches-paths.py | ||
| standards-touched-selftest.sh | ||
| standards-touched.py | ||
| test-public-text-checks.sh | ||
| wai-quantum-webgpu-member.sh | ||