62c4ce84b3
Some checks failed
wai cross-architecture byte-equality / linux-x86_64 (pull_request) Failing after 18s
wai cross-architecture byte-equality / windows-x86_64 (pull_request) Failing after 35s
WAI conformance / cargo-class corpora · linux (pull_request) Successful in 35s
wai cross-architecture byte-equality / linux-aarch64 (pull_request) Failing after 1m5s
WAI conformance / cross-arch byte-equality · linux (pull_request) Failing after 17s
wai cross-architecture byte-equality / macos-arm64 (reference) (pull_request) Failing after 1m22s
WAI conformance / cargo-class corpora · linux-arm64 (pull_request) Successful in 43s
WAI conformance / cross-arch byte-equality · linux-arm64 (pull_request) Failing after 18s
WAI conformance / cargo-class corpora · windows (pull_request) Successful in 1m37s
WAI conformance / cargo-class corpora · macos (pull_request) Successful in 1m0s
WAI conformance / cross-arch byte-equality · windows (pull_request) Failing after 18s
WAI conformance / cross-arch byte-equality · macos (pull_request) Failing after 1m11s
The Windows runner is a host executor whose `bash` resolves to the Store
WSL stub (C:\Users\…\AppData\Local\Microsoft\WindowsApps\bash.exe) — a
whole different OS. wai-conformance set `defaults: run: shell: bash`
globally, so on Windows every step dropped into WSL Linux, where the
Windows rustup/cargo and the Windows checkout don't apply. That is why
`cargo-class corpora · windows` was the lone red in a job that is green on
linux, linux-arm64 and macos.
Fix, matching the fleet convention (Windows → pwsh):
- Drop the global bash default.
- The two genuinely shell-specific steps — the rustup setup and the
corpus-verify helper loop — ship once per shell family, guarded by
`if: matrix.os == 'windows'`. The Windows setup is just `rustup toolchain
install/default` (the box is a host executor that already has rustup); no
curl bootstrap, no bash.
- The bare `cargo …` steps carry no explicit shell, so each runner uses its
native default (bash-family on unix, pwsh on Windows) and runs cargo
identically. Unix behavior is unchanged.
Also pre-installed 1.97.1 on the Windows box (host provisioning, like every
other runner) so the toolchain step is a no-op fetch.
Scope: this unblocks the Windows *shell*. It turns `cargo-class · windows`
green to match the other arches. It does NOT address the byte-equality /
byte-exact jobs, which fail on *every* platform including linux and macOS —
a real cross-platform test failure (golden mismatch or compile error),
independent of shell, and a separate thread.
Co-Authored-By: Claude Opus 4.8 <[email protected]>
74 lines
3 KiB
YAML
74 lines
3 KiB
YAML
name: wai cross-architecture byte-equality
|
|
|
|
# The `replicate` determinism contract, checked on real silicon. WAI claims its
|
|
# integer-exact decode paths (rANS entropy coder, integer fixed-point synthesis)
|
|
# produce BYTE-IDENTICAL output on every machine. This matrix proves it: five
|
|
# OS/arch combinations decode the same fixtures and assert the same golden
|
|
# bytes — rANS streams produced by CompressAI's upstream encoder, and an
|
|
# int_synth output hash produced on the reference machine (macOS arm64). One
|
|
# diverging byte anywhere fails the suite.
|
|
#
|
|
# The conformance crate (`wai/byte-exact-conformance`) #[path]-includes the
|
|
# pure-integer sources from wai-rs — no system codec libraries, no ONNX runtime
|
|
# — so every leg runs in about a minute.
|
|
|
|
on:
|
|
pull_request:
|
|
paths:
|
|
- 'wai/byte-exact-conformance/**'
|
|
- 'wai/wai-rs/src/neural/int_synth.rs'
|
|
- 'wai/wai-rs/src/neural/jpegai_mans.rs'
|
|
- '.github/workflows/wai-byte-equality.yml'
|
|
push:
|
|
branches:
|
|
- main
|
|
paths:
|
|
- 'wai/byte-exact-conformance/**'
|
|
- 'wai/wai-rs/src/neural/int_synth.rs'
|
|
- 'wai/wai-rs/src/neural/jpegai_mans.rs'
|
|
- '.github/workflows/wai-byte-equality.yml'
|
|
|
|
jobs:
|
|
byte-equality:
|
|
name: ${{ matrix.label }}
|
|
runs-on: ${{ matrix.os }}
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
# Self-hosted fleet labels, not GitHub-hosted images. macos-x86_64 is
|
|
# dropped: no Intel-Mac runner exists in the fleet, and by the same
|
|
# argument the cargo-classes matrix already makes, it adds no arch
|
|
# coverage — x86_64 is held by linux-x86_64 and windows-x86_64, arm64
|
|
# by linux-aarch64 and the macos-arm64 reference.
|
|
include:
|
|
- { os: linux, label: linux-x86_64 }
|
|
- { os: linux-arm64, label: linux-aarch64 }
|
|
- { os: macos, label: macos-arm64 (reference) }
|
|
- { os: windows, label: windows-x86_64 }
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
|
|
# unix: bootstrap rustup (docker image ships no Rust; macOS host has it but
|
|
# launchd's PATH omits ~/.cargo/bin). Windows is a host executor with rustup
|
|
# already present, and must use pwsh — its `bash` is the WSL stub.
|
|
- name: Install Rust 1.97.1 (unix)
|
|
if: matrix.os != 'windows'
|
|
shell: bash
|
|
run: |
|
|
export PATH="$HOME/.cargo/bin:$PATH"
|
|
command -v rustup >/dev/null 2>&1 || \
|
|
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile minimal --default-toolchain 1.97.1
|
|
rustup toolchain install 1.97.1 --profile minimal
|
|
rustup default 1.97.1
|
|
echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
|
|
- name: Install Rust 1.97.1 (Windows)
|
|
if: matrix.os == 'windows'
|
|
shell: pwsh
|
|
run: |
|
|
rustup toolchain install 1.97.1 --profile minimal
|
|
rustup default 1.97.1
|
|
|
|
- name: Decode fixtures, assert golden bytes
|
|
working-directory: wai/byte-exact-conformance
|
|
run: cargo test --release -- --nocapture
|