extensions/conformance-results.md specifies the record a conformance run signs: its members (§2) and corpus digest (§2.1), its signing input (the domain `wai:conform-result` and 0x01, then the record without `sig` in RFC 8785 form) and Ed25519 signature under SPEC §7's strict rule (§3), what a verifier checks and in what order (§4: it reads, its version, its members, its signature, its summary, its verdict) and the codes of each refusal (§5). conform-result/1 is registered as a document kind (registry export and REGISTRY.md regenerated); SPEC §7 points to it. wai-rs gains the module conform_result (feature conform_result, in quickstart): sign, check and verdict, the corpus digest, and the corpus of §7, whose outcomes are stated from the text and asserted before anything is written. `wai conform` signs with it and `wai verify` checks with it. conform-result-conformance/ holds accepted records and refused ones (a case flipped, the corpus digest changed, the summary alone changed, a bad signature, S past L, a small-order key, a summary or verdict that disagrees though signed, an unknown version, members missing, added or named twice, a fractional count, a digest out of form, bytes that are not JSON); wai_conform_result_vectors generates and verifies it, and conform_result_verify.py, written from the text and sharing no code with wai-rs, reaches every outcome and fails the corpus with each check of §4 left out. `wai conform` gains the verifier suite conform-result. `wai breaking` leaves out an explicit list of corpus files that record a measured run (the format probes' external decodes, the relay's recorded metering run), each with its reason, and says so in a note; the vectors built from them stay compared. A command `wai conform` runs is put in a process group of its own, so a timed-out command's children are stopped too. Co-Authored-By: Claude Opus 5.5 <[email protected]>
158 lines
7.7 KiB
YAML
158 lines
7.7 KiB
YAML
name: WAI breaking changes and the conformance runner
|
|
|
|
# The gate WAI's libraries are published behind (toolchain v1, decision 7): every pull request
|
|
# that touches WAI runs `wai breaking --against origin/main`, and fails on a breaking change that
|
|
# wai/CHANGELOG.md does not name. Two jobs:
|
|
#
|
|
# - breaking: the check itself, against the merge base of the pull request and main, in all
|
|
# three categories: wire (the registry export, the media and delivery corpora), record (the
|
|
# signing domains, magics and versions, the record corpora, the published JSON Schemas) and
|
|
# API (the Rust public API of the WAI library crates through rustdoc's JSON, the C header,
|
|
# the room service's OpenAPI document).
|
|
# - runner: the tests of `wai breaking` (each kind of break reported and failing until a
|
|
# changelog entry names it) and of `wai conform` (the reference implementations conform, a
|
|
# changed verdict or output byte fails, a changed record is refused by `wai verify`); then
|
|
# `wai conform` runs the corpora's independent Python verifiers and the reference packager,
|
|
# and `wai verify` checks every record those runs wrote.
|
|
#
|
|
# Push filters match the push's delta, and the `relevant` job gates the work from the pull
|
|
# request's own diff (scripts/pr-touches-paths.py, reading the list below), as wai-pack.yml
|
|
# explains.
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
on:
|
|
pull_request:
|
|
paths:
|
|
- 'wai/**'
|
|
# The room service's API is part of the API category.
|
|
- 'joule-code/joule-code-rs/crates/joule-moq-room/openapi.json'
|
|
# The toolchain pin decides which compiler documents both sides of the Rust API.
|
|
- 'rust-toolchain.toml'
|
|
- 'scripts/pr-touches-paths.py'
|
|
- '.github/workflows/wai-breaking.yml'
|
|
|
|
jobs:
|
|
relevant:
|
|
name: WAI breaking · does this change touch WAI
|
|
runs-on: linux-arm64
|
|
outputs:
|
|
run: ${{ steps.gate.outputs.run }}
|
|
steps:
|
|
- uses: actions/checkout@v5
|
|
with:
|
|
fetch-depth: 0
|
|
- id: gate
|
|
run: |
|
|
set -euo pipefail
|
|
r=$(python3 scripts/pr-touches-paths.py .github/workflows/wai-breaking.yml \
|
|
"${{ github.event.pull_request.base.sha }}" \
|
|
"${{ github.event.pull_request.head.sha }}")
|
|
echo "this change touches WAI: $r"
|
|
echo "run=$r" >> "$GITHUB_OUTPUT"
|
|
|
|
breaking:
|
|
name: WAI breaking · wire, record and API against main · linux
|
|
needs: relevant
|
|
if: needs.relevant.outputs.run == 'true'
|
|
runs-on: linux
|
|
timeout-minutes: 60
|
|
steps:
|
|
- uses: actions/checkout@v5
|
|
with:
|
|
fetch-depth: 0
|
|
- name: Install Rust 1.98.0
|
|
shell: bash
|
|
run: |
|
|
export PATH="$HOME/.cargo/bin:$PATH"
|
|
command -v rustup >/dev/null 2>&1 || \
|
|
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile minimal --default-toolchain 1.98.0
|
|
rustup toolchain install 1.98.0 --profile minimal
|
|
rustup default 1.98.0
|
|
SUDO=""; [ "$(id -u)" -ne 0 ] && SUDO="sudo"
|
|
command -v python3 >/dev/null || { $SUDO apt-get update -qq; $SUDO apt-get install -y -qq python3; }
|
|
echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
|
|
- name: Build wai
|
|
working-directory: wai/wai-rs
|
|
shell: bash
|
|
run: |
|
|
set -euo pipefail
|
|
cargo build --locked --no-default-features --bin wai
|
|
out=$(cargo metadata --format-version 1 --no-deps --locked | python3 -c 'import json,sys; print(json.load(sys.stdin)["target_directory"])')
|
|
mkdir -p "$RUNNER_TEMP/bin" && cp "$out/debug/wai" "$RUNNER_TEMP/bin/"
|
|
# The base is main's tip as fetched now; `wai breaking` compares against its merge base
|
|
# with this pull request, so what main gained since the branch left it is not read as
|
|
# this change removing it. Every finding is printed: each break with its category, what
|
|
# changed and why it breaks, and the line that acknowledges it if it is intended.
|
|
- name: wai breaking --against origin/main
|
|
shell: bash
|
|
run: |
|
|
set -euo pipefail
|
|
# The job's container user may not own the checkout; git then refuses to read it.
|
|
git config --global --add safe.directory "$GITHUB_WORKSPACE"
|
|
git fetch -q --no-tags origin +refs/heads/main:refs/remotes/origin/main
|
|
"$RUNNER_TEMP/bin/wai" breaking --against origin/main --text --all
|
|
|
|
runner:
|
|
name: WAI breaking and conform · their tests, and the independent verifiers through wai conform · linux
|
|
needs: relevant
|
|
if: needs.relevant.outputs.run == 'true'
|
|
runs-on: linux
|
|
timeout-minutes: 90
|
|
steps:
|
|
- uses: actions/checkout@v5
|
|
- name: Install Rust 1.98.0
|
|
shell: bash
|
|
run: |
|
|
export PATH="$HOME/.cargo/bin:$PATH"
|
|
command -v rustup >/dev/null 2>&1 || \
|
|
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile minimal --default-toolchain 1.98.0
|
|
rustup toolchain install 1.98.0 --profile minimal
|
|
rustup default 1.98.0
|
|
echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
|
|
- uses: actions/setup-python@v5
|
|
with:
|
|
python-version: '3.11'
|
|
# claim_verify.py, jwp_verify.py and signer_verify.py check Ed25519's equation with it.
|
|
- name: Install the Ed25519 library
|
|
shell: bash
|
|
run: python -m pip install cryptography
|
|
# The tests build fixture repositories with git and document a fixture crate with rustdoc.
|
|
- name: The tests of wai breaking and wai conform
|
|
working-directory: wai/wai-rs
|
|
shell: bash
|
|
run: |
|
|
set -euo pipefail
|
|
git config --global --add safe.directory "$GITHUB_WORKSPACE"
|
|
git config --global user.email [email protected]
|
|
git config --global user.name ci
|
|
cargo test --locked --no-default-features --features quickstart,score,key_discovery \
|
|
--bin wai --test cli_breaking --test cli_conform
|
|
- name: Build wai and the reference packager
|
|
shell: bash
|
|
run: |
|
|
set -euo pipefail
|
|
out() { (cd "$1" && cargo metadata --format-version 1 --no-deps --locked | python3 -c 'import json,sys; print(json.load(sys.stdin)["target_directory"])'); }
|
|
mkdir -p "$RUNNER_TEMP/bin"
|
|
(cd wai/wai-rs && cargo build --locked --no-default-features --features quickstart --bin wai) && cp "$(out wai/wai-rs)/debug/wai" "$RUNNER_TEMP/bin/"
|
|
(cd wai/wai-pack && cargo build --locked --bin wai-pack) && cp "$(out wai/wai-pack)/debug/wai-pack" "$RUNNER_TEMP/bin/"
|
|
# The second implementations of the claim, JWP and key-discovery corpora, written from the
|
|
# extension texts and sharing no code with wai-rs, run through the conformance runner as
|
|
# any other implementation would be; then the reference packager's policy reader. Each
|
|
# run must be conformant, and every record it signs must verify.
|
|
- name: wai conform with the independent verifiers and the reference packager
|
|
shell: bash
|
|
run: |
|
|
set -euo pipefail
|
|
w="$RUNNER_TEMP/bin/wai"; d="$RUNNER_TEMP/conform"; mkdir -p "$d"
|
|
for s in claim jwp signer; do
|
|
"$w" conform verifier --suite "$s" --text --root wai \
|
|
--impl "python3 -I wai/$s-conformance/${s}_verify.py verdicts {corpus}" --out "$d/$s.wai-conform.json"
|
|
done
|
|
"$w" conform verifier --suite conform-result --text --root wai \
|
|
--impl "python3 -I wai/conform-result-conformance/conform_result_verify.py verdicts {corpus}" --out "$d/conform-result.wai-conform.json"
|
|
"$w" conform packager --suite policy --text --root wai \
|
|
--impl "$RUNNER_TEMP/bin/wai-pack policy-verdict {in}" --out "$d/policy.wai-conform.json"
|
|
"$w" verify "$d"
|