IOReport meters: the two clippy warnings each macOS reader carried #244

Merged

dcharlot merged 1 commit from fix/ioreport-meter-lints into main 2026-10-14 09:09:23 -04:00

Conversation 0 Commits 1 Files changed 3 +12 -4

dcharlot commented 2026-10-14 01:19:57 -04:00

Owner

Copy link

What was wrong

Three crates carry the same IOReport energy reader: proof-cascade, eoc-meter and jouleclaw-energy. Clippy warned twice in each of them. The code only builds on macOS, so a Linux run never sees these warnings.

• duplicated_attributes fires on the empty extern block that links IOReport, IOKit and CoreFoundation. Two of those links use kind = "framework", and the lint reads the repeated key as a duplicate. They are three distinct libraries, so the lint is allowed with that reason, as jcp-energy has done since June.
• manual_c_str_literals: b"IOReportChannels\0" becomes c"IOReportChannels", the form these files already use for their other keys. The pointer passed to CFStringCreateWithCString is unchanged.

Checked

A macOS sweep of every workspace (cargo clippy --all-targets --keep-going, on main with #241 merged in) found no deny-level error in any workspace. The 6 warnings here were the only instances of either lint.

On the build host, after the change:

• clippy no longer reports either lint for the three crates;
• the meter tests pass with live IOReport readings: proof-cascade 111, eoc-meter 86, jouleclaw-energy (--features ioreport) 129.

No file overlaps #241.

🤖 Generated with Claude Code

## What was wrong Three crates carry the same IOReport energy reader: proof-cascade, eoc-meter and jouleclaw-energy. Clippy warned twice in each of them. The code only builds on macOS, so a Linux run never sees these warnings. - **`duplicated_attributes`** fires on the empty `extern` block that links IOReport, IOKit and CoreFoundation. Two of those links use `kind = "framework"`, and the lint reads the repeated key as a duplicate. They are three distinct libraries, so the lint is allowed with that reason, as jcp-energy has done since June. - **`manual_c_str_literals`**: `b"IOReportChannels\0"` becomes `c"IOReportChannels"`, the form these files already use for their other keys. The pointer passed to `CFStringCreateWithCString` is unchanged. ## Checked A macOS sweep of every workspace (`cargo clippy --all-targets --keep-going`, on main with #241 merged in) found no deny-level error in any workspace. The 6 warnings here were the only instances of either lint. On the build host, after the change: - clippy no longer reports either lint for the three crates; - the meter tests pass with live IOReport readings: proof-cascade 111, eoc-meter 86, jouleclaw-energy (`--features ioreport`) 129. No file overlaps #241. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

dcharlot added 1 commit 2026-10-14 01:19:57 -04:00

IOReport meters: the two clippy warnings each macOS reader carried ... c597406838

proof-cascade, eoc-meter and jouleclaw-energy share an IOReport reader, and
clippy warned twice in each, only on macOS (the code is gated there):

- duplicated_attributes on the empty extern block that links IOReport,
  IOKit and CoreFoundation. The lint reads the repeated `kind` key across
  separate `#[link]`s as a duplicate. The links are three distinct libraries,
  so it is allowed with that reason, as jcp-energy already does.
- manual_c_str_literals: `b"IOReportChannels\0"` is now `c"IOReportChannels"`,
  as the other keys in these files already are.

A macOS sweep of every workspace (`cargo clippy --all-targets --keep-going`)
found no deny-level error anywhere; these six were the only instances of
either lint. Meter tests pass on the build host: proof-cascade 111,
eoc-meter 86, jouleclaw-energy (ioreport) 129.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

dcharlot merged commit db62cc16d3 into main 2026-10-14 09:09:23 -04:00

dcharlot referenced this pull request from a commit 2026-10-14 09:09:23 -04:00

Merge pull request 'IOReport meters: the two clippy warnings each macOS reader carried' (#244) from fix/ioreport-meter-lints into main

dcharlot referenced this pull request from a commit 2026-10-14 11:58:07 -04:00

jouleclaw-energy: a ledger total carries its weakest grade; macOS meter code is linted in CI

dcharlot referenced this pull request 2026-10-14 11:58:09 -04:00

jouleclaw-energy: a ledger total carries its weakest grade; macOS meter code is linted in CI #259

dcharlot referenced this pull request from a commit 2026-10-20 08:39:06 -04:00

jouleclaw fabrics: pin metal's clippy count — nothing was linting it

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

Transaction-Science/open-standards!244

No description provided.