Transaction-Science/open-standards
Watch
1
0
Fork
You've already forked open-standards
 0
Code Issues Pull requests Projects Releases 15 Packages Wiki Activity Actions 11

IOReport meters: the two clippy warnings each macOS reader carried #244

Merged
dcharlot merged 1 commit from fix/ioreport-meter-lints into main 2026-10-14 09:09:23 -04:00
Conversation 0 Commits 1 Files changed 3 +12 -4
3 changed files with 12 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
eoc/eoc-rs/crates/eoc-meter/src/lib.rs
View file

@ -1617,6 +1617,9 @@ mod macos_ioreport {
) -> bool;
}
// Three distinct frameworks, each legitimately `kind = "framework"`; the
// lint mis-reads the repeated key across separate `#[link]`s as a duplicate.
#[allow(clippy::duplicated_attributes)]
#[link(name = "IOReport", kind = "dylib")]
#[link(name = "IOKit", kind = "framework")]
#[link(name = "CoreFoundation", kind = "framework")]
@ -2010,7 +2013,7 @@ mod macos_ioreport {
unsafe {
let key = CFStringCreateWithCString(
std::ptr::null_mut(),
b"IOReportChannels\0".as_ptr() as *const _,
c"IOReportChannels".as_ptr() as *const _,
K_CFSTRING_ENCODING_UTF8,
);
if key.is_null() {

6
jouleclaw/jouleclaw-rs/crates/jouleclaw-energy/src/apple_ioreport.rs
View file

@ -131,7 +131,9 @@ unsafe extern "C" {
// IOReport's symbols live in the dyld shared cache (no on-disk framework
// bundle since Big Sur), so link it as a dylib; IOKit + CoreFoundation are
// real frameworks.
// real frameworks. Clippy mis-reads the repeated `kind` key across separate
// `#[link]`s as a duplicate attribute.
#[allow(clippy::duplicated_attributes)]
#[link(name = "IOReport", kind = "dylib")]
#[link(name = "IOKit", kind = "framework")]
#[link(name = "CoreFoundation", kind = "framework")]
@ -1037,7 +1039,7 @@ fn sum_energy_uj(delta: CFDictionaryRef) -> u64 {
unsafe {
let key = CFStringCreateWithCString(
std::ptr::null_mut(),
b"IOReportChannels\0".as_ptr() as *const _,
c"IOReportChannels".as_ptr() as *const _,
K_CFSTRING_ENCODING_UTF8,
);
if key.is_null() {

5
proof/proof-rs/crates/proof-cascade/src/meter.rs
View file

@ -3189,6 +3189,9 @@ mod macos_ioreport {
) -> bool;
}
// Three distinct frameworks, each legitimately `kind = "framework"`; the
// lint mis-reads the repeated key across separate `#[link]`s as a duplicate.
#[allow(clippy::duplicated_attributes)]
#[link(name = "IOReport", kind = "dylib")]
#[link(name = "IOKit", kind = "framework")]
#[link(name = "CoreFoundation", kind = "framework")]
@ -3422,7 +3425,7 @@ mod macos_ioreport {
unsafe fn sum_energy_uj(delta: CFDictionaryRef) -> u64 {
let key = CFStringCreateWithCString(
std::ptr::null_mut(),
b"IOReportChannels\0".as_ptr() as *const _,
c"IOReportChannels".as_ptr() as *const _,
K_CFSTRING_ENCODING_UTF8,
);
if key.is_null() {