check: no library source file is unreachable from its crate root #142

Merged

dcharlot merged 2 commits from sandbox/meter-delta-read into main 2026-10-13 06:37:24 -04:00

Conversation 0 Commits 2 Files changed 4 +250 -4

dcharlot commented 2026-10-02 00:46:34 -04:00

Owner

Copy link

Going after the meters turned up a worse instance of a family this repo keeps finding.

jouleclaw-omni/src/runtime/energy.rs documents itself as measuring "actual GPU, CPU, ANE and DRAM energy consumption in joules using Apple's IOReport framework." It does not call IOReport. The macOS path multiplies getrusage CPU seconds by a fixed 15 W; the other path multiplies wall-clock by 45 W; each then splits the result 60/20/20 across subsystems by constant fractions. Zero tests. And runtime/mod.rs does not declare it — so it has never been compiled, by anything, ever.

Why an orphan is the strongest member of the family

A feature-gated test with no --features reports zero tests. A platform-gated meter on a single-platform runner compiles out. A conformance suite in main() gets built and never run. An orphan source file does not even type-check — invisible to cargo check, cargo test, clippy and every conformance suite simultaneously, and it cannot fail because nothing asks it anything.

The hazard is the next reader, not the dead code. A real meter with a per-rail liveness gate already lives in the same workspace (jouleclaw-energy). Someone who trusts this file's header and wires it in instead gets CPU-seconds × a guess, apportioned by invented fractions — energy derived from a performance proxy, which is precisely what the metering ladder exists to grade against.

Worth naming separately: the per-subsystem split. Four fields reading as four independent observations when all four are fractions of one number is precision standing in for measurement, and it invites per-subsystem conclusions nothing here could support.

Measured, not estimated

1659 library sources checked. 25 orphans, all in jouleclaw-omni, 19,964 lines never compiled. Every other crate is clean.

My first pass said 77 — it counted src/bin/*.rs, which cargo auto-discovers, so the exclusions are part of the check rather than a convenience. The baseline was then generated by the detector instead of retyped, because hand-copying it pinned 15 of 25 and the check caught the other ten.

Falsified in both directions

A planted orphan must fail the check; removing it must pass. The CI step repeats that self-test on every run, so the guard cannot quietly stop gating. Exit codes were verified without a pipe — $? after | head is head's status, which is exactly how a gate stops gating unnoticed.

The baseline pins today's 25 so this does not go red on a pre-existing condition, and names what the file falsely claims. Removing an entry is the point; adding one is a regression to argue for in a commit message.

What I deliberately did not do

energy.rs gets a corrected header and nothing else. I had added a declared EnergyBasis to it and reverted that — the field made the orphan stop compiling, and a broken orphan is worse than an honest one.

Whether those 25 files get wired up or deleted is not mine to decide. 20k lines is someone's work, and the guard stops the problem growing either way.

🤖 Generated with Claude Code

Going after the meters turned up a worse instance of a family this repo keeps finding. `jouleclaw-omni/src/runtime/energy.rs` documents itself as measuring *"actual GPU, CPU, ANE and DRAM energy consumption in joules using Apple's IOReport framework."* It does not call IOReport. The macOS path multiplies `getrusage` CPU seconds by a fixed **15 W**; the other path multiplies wall-clock by **45 W**; each then splits the result **60/20/20** across subsystems by constant fractions. Zero tests. And `runtime/mod.rs` does not declare it — so it has **never been compiled, by anything, ever.** ## Why an orphan is the strongest member of the family A feature-gated test with no `--features` reports zero tests. A platform-gated meter on a single-platform runner compiles out. A conformance suite in `main()` gets built and never run. An orphan source file **does not even type-check** — invisible to cargo check, cargo test, clippy and every conformance suite simultaneously, and it cannot fail because nothing asks it anything. The hazard is the next reader, not the dead code. A real meter with a per-rail liveness gate already lives in the same workspace (`jouleclaw-energy`). Someone who trusts this file's header and wires it in instead gets CPU-seconds × a guess, apportioned by invented fractions — energy derived from a performance proxy, which is precisely what the metering ladder exists to grade against. Worth naming separately: the per-subsystem split. Four fields reading as four independent observations when all four are fractions of one number is **precision standing in for measurement**, and it invites per-subsystem conclusions nothing here could support. ## Measured, not estimated 1659 library sources checked. **25 orphans, all in `jouleclaw-omni`, 19,964 lines never compiled.** Every other crate is clean. My first pass said 77 — it counted `src/bin/*.rs`, which cargo auto-discovers, so the exclusions are part of the check rather than a convenience. The baseline was then generated **by the detector** instead of retyped, because hand-copying it pinned 15 of 25 and the check caught the other ten. ## Falsified in both directions A planted orphan must fail the check; removing it must pass. The CI step **repeats that self-test on every run**, so the guard cannot quietly stop gating. Exit codes were verified without a pipe — `$?` after `| head` is head's status, which is exactly how a gate stops gating unnoticed. The baseline pins today's 25 so this does not go red on a pre-existing condition, and names what the file falsely claims. Removing an entry is the point; adding one is a regression to argue for in a commit message. ## What I deliberately did not do `energy.rs` gets a corrected header and nothing else. I had added a declared `EnergyBasis` to it and **reverted that** — the field made the orphan stop compiling, and a broken orphan is worse than an honest one. Whether those 25 files get wired up or deleted is not mine to decide. 20k lines is someone's work, and the guard stops the problem growing either way. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

dcharlot added 1 commit 2026-10-02 00:46:34 -04:00

check: no library source file is unreachable from its crate root ... 7a82d53469

Going after the meters turned up a worse instance of a family this repo keeps
finding. `jouleclaw-omni/src/runtime/energy.rs` documents itself as measuring
"actual GPU, CPU, ANE and DRAM energy consumption in joules using Apple's
IOReport framework". It does not call IOReport. The macOS path multiplies
`getrusage` CPU seconds by a fixed 15 W; the other path multiplies wall-clock by
45 W; each then splits the result 60/20/20 across subsystems by constant
fractions. It has **zero tests**, and `runtime/mod.rs` does not declare it — so
it has never been compiled, by anything, ever.

That is the strongest member of the family. A feature-gated test with no
`--features` reports zero tests; a platform-gated meter on a single-platform
runner compiles out; a conformance suite in `main()` gets built and never run.
An orphan source file does not even type-check. It is invisible to cargo check,
cargo test, clippy and every conformance suite simultaneously, and it cannot
fail because nothing asks it anything.

The hazard is the next reader, not the dead code. A real meter with a per-rail
liveness gate already lives in the same workspace (`jouleclaw-energy`); someone
who trusts this file's header and wires it in instead gets CPU-seconds times a
guess, apportioned by invented fractions — energy derived from a performance
proxy, which is the thing the whole metering ladder exists to grade against.

So: `scripts/check-orphan-sources.py`, wired into the hygiene workflow. The
per-subsystem split is worth naming separately — four fields reading as four
independent observations when all four are fractions of one number is precision
standing in for measurement, and it invites conclusions nothing here supports.

**Measured, not estimated.** 1659 library sources checked; 25 orphans, all in
`jouleclaw-omni`, 19,964 lines never compiled. Every other crate is clean.
My first pass said 77 — it counted `src/bin/*.rs`, which cargo auto-discovers,
so the exclusions are part of the check rather than a convenience. The baseline
was then generated by the detector instead of retyped, because hand-copying it
pinned 15 of 25 and the check caught the other ten.

Falsified in both directions before being trusted, and the CI step repeats the
self-test on every run: a planted orphan must fail the check, and removing it
must pass. Exit codes verified without a pipe — `$?` after `| head` is head's
status, which is how a gate silently stops gating.

The baseline pins today's 25 so this does not go red on a pre-existing
condition, and names what the file falsely claims. Removing an entry is the
point; adding one is a regression to argue for in a commit message.

`energy.rs` itself gets a corrected header and nothing else. I had added a
declared `EnergyBasis` to it and reverted that: the field made the orphan stop
compiling, and a broken orphan is worse than an honest one. Whether those 25
files are wired up or deleted is not mine to decide — 20k lines is someone's
work, and the guard stops the problem growing either way.

Co-Authored-By: Claude Opus 5 <[email protected]>

dcharlot force-pushed sandbox/meter-delta-read from 7a82d53469 to 0c0b66f001 2026-10-10 09:54:56 -04:00 Compare

dcharlot referenced this pull request 2026-10-11 22:59:51 -04:00

wai-vector: the default stroke set and the test repertoire, as WSF1 sources expanded by Annex A, and the text vectors (D7-5) #224

dcharlot merged commit 2d73ce553c into main 2026-10-13 06:37:24 -04:00

dcharlot referenced this pull request from a commit 2026-10-13 06:37:24 -04:00

check: no library source file is unreachable from its crate root (#142)

dcharlot referenced this pull request from a commit 2026-10-14 02:13:13 -04:00

Merge origin/main (at bd3983c6, with #229-#232, #235, #142, #209, #210) into wai/d2c-decoders-on-ops

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

Transaction-Science/open-standards!142

No description provided.