Move the toolchain pin to Rust 1.97.1 #38
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "rust-toolchain-1.97.1"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The repo was pinned to 1.96.0 while 1.97.1 is current and installed on the dev box — so every build here ran a compiler two releases behind the one the code is actually developed against. All of PR #31 and #34 were written and verified under 1.97.1 locally, then would have been gated by 1.96.0 in CI. This closes that gap.
What moved
Both toolchain files, and the five workflows that hardcode a toolchain instead of deferring to
rust-toolchain.toml:rust-toolchain.tomleoc/eoc-rs/rust-toolchain.tomlwai-conformance.yml(×2 jobs)wai-neural-e2e.ymlwai-byte-equality.ymljoule-code-conformance.ymljouleclaw-public-surface-documented.ymlThe pin stays exact. A pin that drifts is not a pin — the point is that CI and every contributor build the same compiler, and
stablewould silently move under us.MSRV deliberately untouched
The
rust-versionfields across the workspaces (1.85 in mesh/proof, 1.96 elsewhere) are a floor, not a pin: they declare the oldest compiler a crate supports, not the one it is built with. A crate with MSRV 1.85 builds perfectly well under 1.97.1.Raising them because a build box moved would narrow who can consume these standards as libraries — that is a policy decision about support commitments, not a consequence of upgrading a toolchain. If the intent is to raise the support floor too, that is a separate, deliberate change.
Verified under the new pin
rustc 1.97.1 (8bab26f4f)resolving from the pin in every case — not from an ambientstable:cargo checkexit 0, 15 tests passeoc/eoc-rssub-workspace, which carries its own toolchain file) — 11 + 3 tests pass--features candle— 19 tests pass; picked deliberately as the heaviest third-party dep tree in the repo (candle + tokenizers), the most likely thing to break on a compiler bumprustup pulled 1.97.1 on first use, which is the same thing each CI runner will do once on its next build.
Note on CI
Actions is still disabled on this repo (
has_actions: false), so these workflow edits will not execute until it is enabled — they are correct-when-turned-on, not verified-by-running.🤖 Generated with Claude Code