ci: per-OS shells (pwsh on Windows, bash on unix) #48
Merged
dcharlot
merged 1 commit from 2026-07-26 06:01:23 -04:00
ci-windows-shell into main 2026-07-26
ci: per-OS shells so the Windows leg stops running in WSL
Some checks failed
wai cross-architecture byte-equality / linux-x86_64 (pull_request) Failing after 18s
wai cross-architecture byte-equality / windows-x86_64 (pull_request) Failing after 35s
WAI conformance / cargo-class corpora · linux (pull_request) Successful in 35s
wai cross-architecture byte-equality / linux-aarch64 (pull_request) Failing after 1m5s
WAI conformance / cross-arch byte-equality · linux (pull_request) Failing after 17s
wai cross-architecture byte-equality / macos-arm64 (reference) (pull_request) Failing after 1m22s
WAI conformance / cargo-class corpora · linux-arm64 (pull_request) Successful in 43s
WAI conformance / cross-arch byte-equality · linux-arm64 (pull_request) Failing after 18s
WAI conformance / cargo-class corpora · windows (pull_request) Successful in 1m37s
WAI conformance / cargo-class corpora · macos (pull_request) Successful in 1m0s
WAI conformance / cross-arch byte-equality · windows (pull_request) Failing after 18s
WAI conformance / cross-arch byte-equality · macos (pull_request) Failing after 1m11s
The Windows runner is a host executor whose `bash` resolves to the Store
WSL stub (C:\Users\…\AppData\Local\Microsoft\WindowsApps\bash.exe) — a
whole different OS. wai-conformance set `defaults: run: shell: bash`
globally, so on Windows every step dropped into WSL Linux, where the
Windows rustup/cargo and the Windows checkout don't apply. That is why
`cargo-class corpora · windows` was the lone red in a job that is green on
linux, linux-arm64 and macos.
Fix, matching the fleet convention (Windows → pwsh):
- Drop the global bash default.
- The two genuinely shell-specific steps — the rustup setup and the
corpus-verify helper loop — ship once per shell family, guarded by
`if: matrix.os == 'windows'`. The Windows setup is just `rustup toolchain
install/default` (the box is a host executor that already has rustup); no
curl bootstrap, no bash.
- The bare `cargo …` steps carry no explicit shell, so each runner uses its
native default (bash-family on unix, pwsh on Windows) and runs cargo
identically. Unix behavior is unchanged.
Also pre-installed 1.97.1 on the Windows box (host provisioning, like every
other runner) so the toolchain step is a no-op fetch.
Scope: this unblocks the Windows *shell*. It turns `cargo-class · windows`
green to match the other arches. It does NOT address the byte-equality /
byte-exact jobs, which fail on *every* platform including linux and macOS —
a real cross-platform test failure (golden mismatch or compile error),
independent of shell, and a separate thread.
Co-Authored-By: Claude Opus 4.8 <[email protected]>