wai byte-exact conformance: fix stale #[path] includes #49
Loading…
Reference in a new issue
No description provided.
Delete branch "fix-byte-exact-includes"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes the last red thread on the board — the byte-equality suite, which failed on every arch (linux, linux-arm64, macOS/arm64, Windows). That it failed the reference platform ruled out a determinism bug: it was a compile error from stale
#[path]includes, latent since the neural/semantic reconcile and invisible until Actions was turned on.rans.rsmovedwai-rs/src/neural/→wai-rs/src/; the include still pointed at the old location.rans.rs's integer-entropy test needs siblingcrate::int_entropy, which the shim crate never included. Added it verbatim (pure-integer, self-contained).Verified on the reference platform (arm64 macOS):
cargo test --release→ 14/14, including all three goldens. Toucheswai/byte-exact-conformance/**, so both wai-conformance and wai-byte-equality re-run across the full matrix.🤖 Generated with Claude Code
The byte-equality suite failed on all four arches — linux, linux-arm64, macOS/arm64, Windows — which ruled out a determinism bug from the start: a cross-platform divergence cannot fail the *reference* platform. It was a compile error, latent since the neural/semantic reconcile onto main and invisible because Actions had never run. Two stale `#[path]` facts: - `rans.rs` moved from `wai-rs/src/neural/` to `wai-rs/src/`, but the include still pointed at the old `neural/rans.rs` -> file-not-found. - once that resolved, `rans.rs`'s own integer-entropy round-trip test references `crate::int_entropy`, a sibling module the shim crate never included. Added it from wai-rs verbatim -- it is pure-integer and self-contained (its only `crate::` mentions are doc-links), so it fits the crate's single-source-of-truth rule exactly like the neural sources. No source logic changed; only the include wiring. Verified on the reference platform (arm64 macOS): `cargo test --release` -> 14/14 pass, including the three goldens (rANS vs upstream encoder, int_synth output hash, JPEG-AI mANS reference stream). Because the paths sit under `wai/byte-exact-conformance/**`, this PR re-runs both wai-conformance and wai-byte-equality across the full matrix. Co-Authored-By: Claude Opus 4.8 <[email protected]>