wai http origin: a refusal ends cleanly, and origin_per_peer_limit waits for its state #657

Merged

dcharlot merged 1 commit from fix/origin-503-reset into main 2026-11-06 03:40:12 -05:00

Conversation 0 Commits 1 Files changed 3 +56 -18

dcharlot commented 2026-11-05 12:44:23 -05:00

Owner

Copy link

wai http origin ended a refusal in a reset, and origin_per_peer_limit failed under load.

The origin

It answered 503 and closed with the request unread, so the connection ended in a reset after the answer. Clients on Linux and macOS still read the 503, but one reading to the close then got an error. A refused request that wrote at once saw this 300 times in 300, on both systems. For a client past --max-per-peer or --max-connections, the origin now stops sending and reads a little more before closing, which the 431 path already did. Both share drain_before_close.

With this change, 300 of 300 refused requests on each system read the 503 and a clean close, both writing at once and 20 ms late. A refused connection's thread can now last up to about 1 s, bounded by the same limits as the 431 path.

The test

origin_per_peer_limit could fail in three ways under load:

• a third connection could overtake the idle two, so one of them was refused and the count never reached the limit;
• the fixed 200 ms could run out;
• the 2 s read timeout could drop the idle two first.

It now retries an attempt overtaken and waits for each state, with a 30 s deadline and a read timeout that outlasts it. It also requires 200 refusals to read their 503 with no read error and no retry.

Verified

On a Linux build host, Rust 1.99.1:

• origin_per_peer_limit: 12 of 12, and 49 of 50 with ten copies running at once. The one failure was those copies sharing a scratch folder (NotFound), which CI doesn't do.
• All of cli_http: 22 passed.
• Planted, no drain on the 503: fails at once, refusal 0: ... ConnectionReset.
• Planted, a limit never reached: fails at the deadline.

The changelog entry is wai/changes/2026-11-05-origin-refusal-ends-cleanly.md.

🤖 Generated with Claude Code

`wai http origin` ended a refusal in a reset, and `origin_per_peer_limit` failed under load. ## The origin It answered 503 and closed with the request unread, so the connection ended in a reset after the answer. Clients on Linux and macOS still read the 503, but one reading to the close then got an error. A refused request that wrote at once saw this 300 times in 300, on both systems. For a client past `--max-per-peer` or `--max-connections`, the origin now stops sending and reads a little more before closing, which the 431 path already did. Both share `drain_before_close`. With this change, 300 of 300 refused requests on each system read the 503 and a clean close, both writing at once and 20 ms late. A refused connection's thread can now last up to about 1 s, bounded by the same limits as the 431 path. ## The test `origin_per_peer_limit` could fail in three ways under load: - a third connection could overtake the idle two, so one of them was refused and the count never reached the limit; - the fixed 200 ms could run out; - the 2 s read timeout could drop the idle two first. It now retries an attempt overtaken and waits for each state, with a 30 s deadline and a read timeout that outlasts it. It also requires 200 refusals to read their 503 with no read error and no retry. ## Verified On a Linux build host, Rust 1.99.1: - `origin_per_peer_limit`: 12 of 12, and 49 of 50 with ten copies running at once. The one failure was those copies sharing a scratch folder (`NotFound`), which CI doesn't do. - All of `cli_http`: 22 passed. - Planted, no drain on the 503: fails at once, `refusal 0: ... ConnectionReset`. - Planted, a limit never reached: fails at the deadline. The changelog entry is `wai/changes/2026-11-05-origin-refusal-ends-cleanly.md`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

dcharlot added 1 commit 2026-11-05 12:44:23 -05:00

wai http origin: a refusal ends cleanly, and origin_per_peer_limit waits for its state ... 19c4bd0d01

The origin answered 503 and closed with the request unread, so the connection ended
in a reset after the answer. Clients on Linux and macOS still read the 503, but a
client reading to the close then saw an error: 300 of 300 refused requests that
wrote at once. With this change, none of 300 on either system. The 431 path already
stopped sending and read on before closing; both now share that.

origin_per_peer_limit failed under load because a third connection could overtake
the idle two, so one of them was refused and the count never reached the limit, and
because a fixed 200 ms and a 2 s read timeout could both run out. It now retries an
attempt overtaken and waits for each state. It also requires 200 refusals to read
their 503 with no read error and no retry.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

dcharlot merged commit 4e17e96efa into main 2026-11-06 03:40:12 -05:00

dcharlot referenced this pull request from a commit 2026-11-06 03:40:13 -05:00

Merge pull request 'wai http origin: a refusal ends cleanly, and origin_per_peer_limit waits for its state' (#657) from fix/origin-503-reset into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

Transaction-Science/open-standards!657

No description provided.