compliance: grade on water too, and retire the two magic floats (re-land) #76

Merged

dcharlot merged 1 commit from compliance/composite-grade-v2 into main 2026-09-03 15:16:55 -04:00

Conversation 0 Commits 1 Files changed 2 +314

dcharlot commented 2026-09-03 15:16:21 -04:00

Owner

Copy link

Re-land of #71. That PR reported merged=True and closed, but its content never reached main — the same silent clobber this repo hit with #66 earlier. Verified by content probe, not merge status. Rebased onto current main and re-verified: 50 tests pass.

---

EedReport::is_compliant() was pue < 1.5 && renewable_pct >= 50.0 — two hardcoded floats with no provenance, sitting in the same crate as the BandingScale added to replace exactly that pattern. It also silently ignored water, while EedReport has been collecting water_usage_liters all along and the schemes grade on power and water.

The test that proves the deprecation, rather than arguing it: a facility with PUE 1.10 and 2.0 L/kWh passes is_compliant() while its actual grade is F.

• wue_milli_l_per_kwh() returns None, not 0, when IT energy is zero — a 0 would read as perfect water efficiency for a facility that reported nothing.
• CompositeRating combines metrics under a declared rule ("worst of" and "mean of" give different letters for one facility), and keeps its components so a reader sees which axis set the grade.
• grade() takes the scales rather than embedding any — which thresholds apply is the instrument's business.

is_compliant is deprecated rather than deleted: it's public API, and the note carries the reasoning to the call site.

🤖 Generated with Claude Code

**Re-land of #71.** That PR reported `merged=True` and closed, but its content never reached `main` — the same silent clobber this repo hit with #66 earlier. Verified by content probe, not merge status. Rebased onto current `main` and re-verified: 50 tests pass. --- `EedReport::is_compliant()` was `pue < 1.5 && renewable_pct >= 50.0` — two hardcoded floats with no provenance, sitting in the same crate as the `BandingScale` added to replace exactly that pattern. It also **silently ignored water**, while `EedReport` has been collecting `water_usage_liters` all along and the schemes grade on power *and* water. The test that proves the deprecation, rather than arguing it: **a facility with PUE 1.10 and 2.0 L/kWh passes `is_compliant()` while its actual grade is F.** - **`wue_milli_l_per_kwh()`** returns **`None`, not 0**, when IT energy is zero — a 0 would read as *perfect* water efficiency for a facility that reported nothing. - **`CompositeRating`** combines metrics under a **declared** rule ("worst of" and "mean of" give different letters for one facility), and keeps its components so a reader sees *which axis set the grade*. - **`grade()`** *takes* the scales rather than embedding any — which thresholds apply is the instrument's business. `is_compliant` is deprecated rather than deleted: it's public API, and the note carries the reasoning to the call site. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

dcharlot added 1 commit 2026-09-03 15:16:21 -04:00

compliance: grade on water too, and retire the two magic floats ... 3638c805ee

`EedReport::is_compliant()` was `self.pue < 1.5 && self.renewable_pct >= 50.0`:
two hardcoded floats with no provenance, no version, and no way to say which
instrument they encode — the exact shape `BandingScale` was added to replace,
sitting in the same crate, on the path a regulator would read.

It also silently ignored water. `EedReport` has collected `water_usage_liters`
all along, and the schemes that grade facilities grade on power **and** water,
so the check discarded an axis it already had in hand. The test that
demonstrates this is the reason for the deprecation rather than an argument for
it: a facility with PUE 1.10 and 2.0 L/kWh **passes `is_compliant()` while its
actual grade is F**.

Three pieces:

- `wue_milli_l_per_kwh()` derives Water Usage Effectiveness as an integer, and
  returns `None` rather than 0 when IT energy is zero. WUE is undefined there,
  and a 0 would read as *perfect* water efficiency for a facility that reported
  nothing — the flattering direction, which is the one to refuse.
- `CompositeRating` combines several metric ratings into one published grade
  under a **declared** rule. "Worst of" and "mean of" are both defensible and
  give different letters for the same facility, so the rule travels with the
  grade for the same reason a `Rating` carries its scale. It keeps its
  components, so a reader sees *which axis set the grade* — a facility rated D
  on water with an A on power is a materially different thing from one rated D
  on both, and a bare letter cannot tell them apart. `binding_component()` names
  the axis an operator has to improve to move the letter, and `covers()` reports
  whether a required axis was graded at all, because a grade that silently omits
  one is not the scheme's grade.
- `grade()` ties them together, taking the scales rather than embedding any.
  Which thresholds apply is the instrument's business, not this crate's — the
  same reason `BandingScale` still ships no canonical scale.

`is_compliant` is deprecated rather than deleted: it is public API, and the
deprecation note carries the reasoning to the call site, which a silent removal
could not. Pre-existing tests that exercise it keep working under a
module-level allow.

Duplicate metrics are refused: the same axis graded twice votes twice, which
under a worst-of rule is harmless and under any other rule is a silent weighting
nobody declared.

Found by the 2026-08-29 sweep, which flagged both that WUE was not rateable
end-to-end and that this function had survived the change meant to retire it.

Verified: 50 jouleclaw-compliance tests pass (7 new), no clippy warnings in the
crate — the four reported are pre-existing, in jouleclaw-core and
jouleclaw-energy.

dcharlot merged commit 0e06562d19 into main 2026-09-03 15:16:55 -04:00

dcharlot referenced this pull request from a commit 2026-09-03 15:16:56 -04:00

Merge pull request 'compliance: grade on water too, and retire the two magic floats (re-land)' (#76) from compliance/composite-grade-v2 into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

Transaction-Science/open-standards!76

No description provided.